2023-04-18 03:43:29

by Chenggang Wang

Subject: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

The function no longer returns a value, synchronize the comments.

Signed-off-by: [email protected]
---
drivers/thermal/cpuidle_cooling.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
index 4f41102..7779739 100644
--- a/drivers/thermal/cpuidle_cooling.c
+++ b/drivers/thermal/cpuidle_cooling.c
@@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
*
* This function is in charge of creating a cooling device per cpuidle
* driver and register it to the thermal framework.
- *
- * Return: zero on success, or negative value corresponding to the
- * error detected in the underlying subsystems.
*/
void cpuidle_cooling_register(struct cpuidle_driver *drv)
{
--
2.7.4

2023-04-18 04:12:39

by Viresh Kumar

Subject: Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

On 18-04-23, 11:38, Chenggang Wang wrote:
> The function no longer returns a value, synchronize the comments.
>
> Signed-off-by: [email protected]
> ---
> drivers/thermal/cpuidle_cooling.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> index 4f41102..7779739 100644
> --- a/drivers/thermal/cpuidle_cooling.c
> +++ b/drivers/thermal/cpuidle_cooling.c
> @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
> *
> * This function is in charge of creating a cooling device per cpuidle
> * driver and register it to the thermal framework.
> - *
> - * Return: zero on success, or negative value corresponding to the
> - * error detected in the underlying subsystems.
> */
> void cpuidle_cooling_register(struct cpuidle_driver *drv)
> {

Acked-by: Viresh Kumar <[email protected]>

--
viresh

2023-04-18 13:40:37

by Rafael J. Wysocki

Subject: Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

On Tue, Apr 18, 2023 at 5:53 AM Viresh Kumar <[email protected]> wrote:
>
> On 18-04-23, 11:38, Chenggang Wang wrote:
> > The function no longer returns a value, synchronize the comments.
> >
> > Signed-off-by: [email protected]
> > ---
> > drivers/thermal/cpuidle_cooling.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
> > index 4f41102..7779739 100644
> > --- a/drivers/thermal/cpuidle_cooling.c
> > +++ b/drivers/thermal/cpuidle_cooling.c
> > @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
> > *
> > * This function is in charge of creating a cooling device per cpuidle
> > * driver and register it to the thermal framework.
> > - *
> > - * Return: zero on success, or negative value corresponding to the
> > - * error detected in the underlying subsystems.
> > */
> > void cpuidle_cooling_register(struct cpuidle_driver *drv)
> > {
>
> Acked-by: Viresh Kumar <[email protected]>

Daniel, are you going to pick up this one?

2023-04-18 13:43:12

by Daniel Lezcano

Subject: Re: [PATCH] thermal/drivers/cpuidle_cooling: Delete unmatched comments

On 18/04/2023 15:30, Rafael J. Wysocki wrote:
> On Tue, Apr 18, 2023 at 5:53 AM Viresh Kumar <[email protected]> wrote:
>>
>> On 18-04-23, 11:38, Chenggang Wang wrote:
>>> The function no longer returns a value, synchronize the comments.
>>>
>>> Signed-off-by: [email protected]
>>> ---
>>> drivers/thermal/cpuidle_cooling.c | 3 ---
>>> 1 file changed, 3 deletions(-)
>>>
>>> diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
>>> index 4f41102..7779739 100644
>>> --- a/drivers/thermal/cpuidle_cooling.c
>>> +++ b/drivers/thermal/cpuidle_cooling.c
>>> @@ -236,9 +236,6 @@ static int __cpuidle_cooling_register(struct device_node *np,
>>> *
>>> * This function is in charge of creating a cooling device per cpuidle
>>> * driver and register it to the thermal framework.
>>> - *
>>> - * Return: zero on success, or negative value corresponding to the
>>> - * error detected in the underlying subsystems.
>>> */
>>> void cpuidle_cooling_register(struct cpuidle_driver *drv)
>>> {
>>
>> Acked-by: Viresh Kumar <[email protected]>
>
> Daniel, are you going to pick up this one?

Yes

--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog