2023-04-18 15:19:21

by Rob Herring (Arm)

[permalink] [raw]
Subject: [PATCH] dt-bindings: display: Fix lvds.yaml references

The trailing "/" in "lvds.yaml/#" is not a valid JSON pointer. The existing
jsonschema package allows it, but coming changes make allowed "$ref" URIs
stricter.

Signed-off-by: Rob Herring <[email protected]>
---
.../devicetree/bindings/display/panel/advantech,idk-1110wr.yaml | 2 +-
.../devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml | 2 +-
.../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 2 +-
.../devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml | 2 +-
Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 +-
.../devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
index 3a8c2c11f9bd..f6fea9085aab 100644
--- a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
+++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
diff --git a/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml b/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
index 566e11f6bfc0..ab6b7be88341 100644
--- a/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
+++ b/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
index 5cf3c588f46d..3623ffa6518d 100644
--- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
index 54750cc5440d..37f01d847aac 100644
--- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
+++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
index c77ee034310a..929fe046d1e7 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
diff --git a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
index 2e75e3738ff0..e32d9188a3e0 100644
--- a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
+++ b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
@@ -12,7 +12,7 @@ maintainers:

allOf:
- $ref: panel-common.yaml#
- - $ref: /schemas/display/lvds.yaml/#
+ - $ref: /schemas/display/lvds.yaml#

select:
properties:
--
2.39.2


2023-04-18 15:33:08

by Laurent Pinchart

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: display: Fix lvds.yaml references

Hi Rob,

Thank you for the patch.

On Tue, Apr 18, 2023 at 10:06:57AM -0500, Rob Herring wrote:
> The trailing "/" in "lvds.yaml/#" is not a valid JSON pointer. The existing
> jsonschema package allows it, but coming changes make allowed "$ref" URIs
> stricter.
>
> Signed-off-by: Rob Herring <[email protected]>

Reviewed-by: Laurent Pinchart <[email protected]>

> ---
> .../devicetree/bindings/display/panel/advantech,idk-1110wr.yaml | 2 +-
> .../devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml | 2 +-
> .../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 2 +-
> .../devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml | 2 +-
> Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 +-
> .../devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> index 3a8c2c11f9bd..f6fea9085aab 100644
> --- a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:
> diff --git a/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml b/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
> index 566e11f6bfc0..ab6b7be88341 100644
> --- a/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:
> diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
> index 5cf3c588f46d..3623ffa6518d 100644
> --- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:
> diff --git a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
> index 54750cc5440d..37f01d847aac 100644
> --- a/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> index c77ee034310a..929fe046d1e7 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-lvds.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:
> diff --git a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
> index 2e75e3738ff0..e32d9188a3e0 100644
> --- a/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml
> @@ -12,7 +12,7 @@ maintainers:
>
> allOf:
> - $ref: panel-common.yaml#
> - - $ref: /schemas/display/lvds.yaml/#
> + - $ref: /schemas/display/lvds.yaml#
>
> select:
> properties:

--
Regards,

Laurent Pinchart

2023-04-20 20:30:54

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: display: Fix lvds.yaml references


On Tue, 18 Apr 2023 10:06:57 -0500, Rob Herring wrote:
> The trailing "/" in "lvds.yaml/#" is not a valid JSON pointer. The existing
> jsonschema package allows it, but coming changes make allowed "$ref" URIs
> stricter.
>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> .../devicetree/bindings/display/panel/advantech,idk-1110wr.yaml | 2 +-
> .../devicetree/bindings/display/panel/innolux,ee101ia-01d.yaml | 2 +-
> .../devicetree/bindings/display/panel/mitsubishi,aa104xd12.yaml | 2 +-
> .../devicetree/bindings/display/panel/mitsubishi,aa121td01.yaml | 2 +-
> Documentation/devicetree/bindings/display/panel/panel-lvds.yaml | 2 +-
> .../devicetree/bindings/display/panel/sgd,gktw70sdae4se.yaml | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>

Applied, thanks!