2023-04-24 15:52:47

by Daeho Jeong

Subject: [PATCH] f2fs: allocate node blocks for atomic write block replacement

From: Daeho Jeong <[email protected]>

When a node block is missing for atomic write block replacement, we need
to allocate it in advance of the replacement.

Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
Signed-off-by: Daeho Jeong <[email protected]>
---
fs/f2fs/segment.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c35476b3c075..0e1e29800934 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -217,7 +217,7 @@ static int __replace_atomic_write_block(struct inode *inode, pgoff_t index,

retry:
set_new_dnode(&dn, inode, NULL, NULL, 0);
- err = f2fs_get_dnode_of_data(&dn, index, LOOKUP_NODE_RA);
+ err = f2fs_get_dnode_of_data(&dn, index, ALLOC_NODE);
if (err) {
if (err == -ENOMEM) {
f2fs_io_schedule_timeout(DEFAULT_IO_TIMEOUT);
--
2.40.0.634.g4ca3ef3211-goog

2023-04-24 16:00:23

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: allocate node blocks for atomic write block replacement

On 2023/4/24 23:44, Daeho Jeong wrote:
> From: Daeho Jeong <[email protected]>
>
> When a node block is missing for atomic write block replacement, we need
> to allocate it in advance of the replacement.
>
> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
> Signed-off-by: Daeho Jeong <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-04-24 18:13:54

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: allocate node blocks for atomic write block replacement

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Mon, 24 Apr 2023 08:44:40 -0700 you wrote:
> From: Daeho Jeong <[email protected]>
>
> When a node block is missing for atomic write block replacement, we need
> to allocate it in advance of the replacement.
>
> Fixes: 3db1de0e582c ("f2fs: change the current atomic write way")
> Signed-off-by: Daeho Jeong <[email protected]>
>
> [...]

Here is the summary with links:
- [f2fs-dev] f2fs: allocate node blocks for atomic write block replacement
https://git.kernel.org/jaegeuk/f2fs/c/994b442b66a4

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html