2023-04-28 12:10:04

by Alexandre Ghiti

Subject: [PATCH -fixes] riscv: Move .rela.dyn to the init sections

The recent introduction of relocatable kernels prepared the move of
.rela.dyn to the init section, but actually forgot to do so, so do it
here.

Before this patch: "Freeing unused kernel image (initmem) memory: 2592K"
After this patch: "Freeing unused kernel image (initmem) memory: 6288K"

The difference corresponds to the size of the .rela.dyn section:
"[42] .rela.dyn RELA ffffffff8197e798 0127f798
000000000039c660 0000000000000018 A 47 0 8"

Fixes: 559d1e45a16d ("riscv: Use --emit-relocs in order to move .rela.dyn in init")
Signed-off-by: Alexandre Ghiti <[email protected]>
---
arch/riscv/kernel/vmlinux.lds.S | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
index 305877d85e96..f03b5697f8e0 100644
--- a/arch/riscv/kernel/vmlinux.lds.S
+++ b/arch/riscv/kernel/vmlinux.lds.S
@@ -104,6 +104,12 @@ SECTIONS
*(.rel.dyn*)
}

+ .rela.dyn : ALIGN(8) {
+ __rela_dyn_start = .;
+ *(.rela .rela*)
+ __rela_dyn_end = .;
+ }
+
__init_data_end = .;

. = ALIGN(8);
@@ -130,12 +136,6 @@ SECTIONS
*(.sdata*)
}

- .rela.dyn : ALIGN(8) {
- __rela_dyn_start = .;
- *(.rela .rela*)
- __rela_dyn_end = .;
- }
-
.got : { *(.got*) }

#ifdef CONFIG_RELOCATABLE
--
2.37.2

2023-05-02 01:06:23

by Palmer Dabbelt

Subject: Re: [PATCH -fixes] riscv: Move .rela.dyn to the init sections

On Fri, 28 Apr 2023 14:09:32 +0200, Alexandre Ghiti wrote:
> The recent introduction of relocatable kernels prepared the move of
> .rela.dyn to the init section, but actually forgot to do so, so do it
> here.
>
> Before this patch: "Freeing unused kernel image (initmem) memory: 2592K"
> After this patch: "Freeing unused kernel image (initmem) memory: 6288K"
>
> [...]

Applied, thanks!

[1/1] riscv: Move .rela.dyn to the init sections
https://git.kernel.org/palmer/c/4db9e253e701

Best regards,
--
Palmer Dabbelt <[email protected]>

2023-05-08 14:55:43

by patchwork-bot+linux-riscv

Subject: Re: [PATCH -fixes] riscv: Move .rela.dyn to the init sections

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:

On Fri, 28 Apr 2023 14:09:32 +0200 you wrote:
> The recent introduction of relocatable kernels prepared the move of
> .rela.dyn to the init section, but actually forgot to do so, so do it
> here.
>
> Before this patch: "Freeing unused kernel image (initmem) memory: 2592K"
> After this patch: "Freeing unused kernel image (initmem) memory: 6288K"
>
> [...]

Here is the summary with links:
- [-fixes] riscv: Move .rela.dyn to the init sections
https://git.kernel.org/riscv/c/4db9e253e701

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html