Having another look at the specs, I finally discovered a testpoint (CP2)
which we could use to test PWM4 on a Falcon board. Thanks go to Kieran
for setting up the scope and do the actual testing. This was the last
missing V3U bit from my side, hooray!
Phong Hoang (1):
arm64: dts: renesas: r8a779a0: Add PWM nodes
Wolfram Sang (1):
clk: renesas: r8a779a0: Add PWM clock
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 50 +++++++++++++++++++++++
drivers/clk/renesas/r8a779a0-cpg-mssr.c | 1 +
2 files changed, 51 insertions(+)
--
2.30.2
From: Phong Hoang <[email protected]>
This patch adds PWM nodes for R-Car V3U (r8a779a0) SoC.
Signed-off-by: Phong Hoang <[email protected]>
[wsa: rebased]
Tested-by: Kieran Bingham <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
---
arch/arm64/boot/dts/renesas/r8a779a0.dtsi | 50 +++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
index bf587a14ec19..7c63591a138f 100644
--- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
@@ -1108,6 +1108,56 @@ msiof5: spi@e6c28000 {
status = "disabled";
};
+ pwm0: pwm@e6e30000 {
+ compatible = "renesas,pwm-r8a779a0", "renesas,pwm-rcar";
+ reg = <0 0xe6e30000 0 0x10>;
+ #pwm-cells = <2>;
+ clocks = <&cpg CPG_MOD 628>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 628>;
+ status = "disabled";
+ };
+
+ pwm1: pwm@e6e31000 {
+ compatible = "renesas,pwm-r8a779a0", "renesas,pwm-rcar";
+ reg = <0 0xe6e31000 0 0x10>;
+ #pwm-cells = <2>;
+ clocks = <&cpg CPG_MOD 628>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 628>;
+ status = "disabled";
+ };
+
+ pwm2: pwm@e6e32000 {
+ compatible = "renesas,pwm-r8a779a0", "renesas,pwm-rcar";
+ reg = <0 0xe6e32000 0 0x10>;
+ #pwm-cells = <2>;
+ clocks = <&cpg CPG_MOD 628>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 628>;
+ status = "disabled";
+ };
+
+ pwm3: pwm@e6e33000 {
+ compatible = "renesas,pwm-r8a779a0", "renesas,pwm-rcar";
+ reg = <0 0xe6e33000 0 0x10>;
+ #pwm-cells = <2>;
+ clocks = <&cpg CPG_MOD 628>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 628>;
+ status = "disabled";
+ };
+
+ pwm4: pwm@e6e34000 {
+ compatible = "renesas,pwm-r8a779a0", "renesas,pwm-rcar";
+ reg = <0 0xe6e34000 0 0x10>;
+ #pwm-cells = <2>;
+ clocks = <&cpg CPG_MOD 628>;
+ power-domains = <&sysc R8A779A0_PD_ALWAYS_ON>;
+ resets = <&cpg 628>;
+ status = "disabled";
+ };
+
vin00: video@e6ef0000 {
compatible = "renesas,vin-r8a779a0";
reg = <0 0xe6ef0000 0 0x1000>;
--
2.30.2
Tested-by: Kieran Bingham <[email protected]>
Signed-off-by: Wolfram Sang <[email protected]>
---
drivers/clk/renesas/r8a779a0-cpg-mssr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/renesas/r8a779a0-cpg-mssr.c b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
index fcc8279647a6..136a0d4e7ed6 100644
--- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
@@ -170,6 +170,7 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
DEF_MOD("msi3", 621, R8A779A0_CLK_MSO),
DEF_MOD("msi4", 622, R8A779A0_CLK_MSO),
DEF_MOD("msi5", 623, R8A779A0_CLK_MSO),
+ DEF_MOD("pwm", 628, R8A779A0_CLK_S1D8),
DEF_MOD("rpc-if", 629, R8A779A0_CLK_RPCD2),
DEF_MOD("scif0", 702, R8A779A0_CLK_S1D8),
DEF_MOD("scif1", 703, R8A779A0_CLK_S1D8),
--
2.30.2
Hi Wolfram,
On Tue, May 2, 2023 at 7:06 PM Wolfram Sang
<[email protected]> wrote:
> Tested-by: Kieran Bingham <[email protected]>
> Signed-off-by: Wolfram Sang <[email protected]>
Thanks for your patch!
> --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> @@ -170,6 +170,7 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
> DEF_MOD("msi3", 621, R8A779A0_CLK_MSO),
> DEF_MOD("msi4", 622, R8A779A0_CLK_MSO),
> DEF_MOD("msi5", 623, R8A779A0_CLK_MSO),
> + DEF_MOD("pwm", 628, R8A779A0_CLK_S1D8),
Do you mind if I rename this to "pwm0" while applying, to match the docs?
Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-clk-for-v6.5.
> DEF_MOD("rpc-if", 629, R8A779A0_CLK_RPCD2),
> DEF_MOD("scif0", 702, R8A779A0_CLK_S1D8),
> DEF_MOD("scif1", 703, R8A779A0_CLK_S1D8),
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Hi Wolfram,
On Tue, May 2, 2023 at 7:06 PM Wolfram Sang
<[email protected]> wrote:
> From: Phong Hoang <[email protected]>
>
> This patch adds PWM nodes for R-Car V3U (r8a779a0) SoC.
>
> Signed-off-by: Phong Hoang <[email protected]>
> [wsa: rebased]
> Tested-by: Kieran Bingham <[email protected]>
> Signed-off-by: Wolfram Sang <[email protected]>
Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in renesas-devel for v6.5.
> --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> @@ -1108,6 +1108,56 @@ msiof5: spi@e6c28000 {
> status = "disabled";
> };
>
> + pwm0: pwm@e6e30000 {
I'll move this before serial@e6e60000 while applying, to preserve sort
order (by unit address).
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
> > + DEF_MOD("pwm", 628, R8A779A0_CLK_S1D8),
>
> Do you mind if I rename this to "pwm0" while applying, to match the docs?
No, feel free. I think it is a bit misleading because the clock is used
up to pwm4. But if the docs have it that way...
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > @@ -1108,6 +1108,56 @@ msiof5: spi@e6c28000 {
> > status = "disabled";
> > };
> >
> > + pwm0: pwm@e6e30000 {
>
> I'll move this before serial@e6e60000 while applying, to preserve sort
> order (by unit address).
Oops, right, things have been added since I last worked on V3U. Thank
you!
Hi Wolfram,
On Wed, May 3, 2023 at 2:41 PM Wolfram Sang
<[email protected]> wrote:
> > > + DEF_MOD("pwm", 628, R8A779A0_CLK_S1D8),
> >
> > Do you mind if I rename this to "pwm0" while applying, to match the docs?
>
> No, feel free. I think it is a bit misleading because the clock is used
> up to pwm4. But if the docs have it that way...
The preliminary R-Car V3U docs _are_ misleading... But it's probably
the best we'd ever get ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
Quoting Geert Uytterhoeven (2023-05-03 11:09:29)
> Hi Wolfram,
>
> On Tue, May 2, 2023 at 7:06 PM Wolfram Sang
> <[email protected]> wrote:
> > Tested-by: Kieran Bingham <[email protected]>
> > Signed-off-by: Wolfram Sang <[email protected]>
>
> Thanks for your patch!
>
> > --- a/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a779a0-cpg-mssr.c
> > @@ -170,6 +170,7 @@ static const struct mssr_mod_clk r8a779a0_mod_clks[] __initconst = {
> > DEF_MOD("msi3", 621, R8A779A0_CLK_MSO),
> > DEF_MOD("msi4", 622, R8A779A0_CLK_MSO),
> > DEF_MOD("msi5", 623, R8A779A0_CLK_MSO),
> > + DEF_MOD("pwm", 628, R8A779A0_CLK_S1D8),
>
> Do you mind if I rename this to "pwm0" while applying, to match the docs?
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in renesas-clk-for-v6.5.
Either way is fine with me, and I've seen this work now so:
Reviewed-by: Kieran Bingham <[email protected]>
>
> > DEF_MOD("rpc-if", 629, R8A779A0_CLK_RPCD2),
> > DEF_MOD("scif0", 702, R8A779A0_CLK_S1D8),
> > DEF_MOD("scif1", 703, R8A779A0_CLK_S1D8),
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Quoting Geert Uytterhoeven (2023-05-03 11:14:52)
> Hi Wolfram,
>
> On Tue, May 2, 2023 at 7:06 PM Wolfram Sang
> <[email protected]> wrote:
> > From: Phong Hoang <[email protected]>
> >
> > This patch adds PWM nodes for R-Car V3U (r8a779a0) SoC.
> >
> > Signed-off-by: Phong Hoang <[email protected]>
> > [wsa: rebased]
> > Tested-by: Kieran Bingham <[email protected]>
> > Signed-off-by: Wolfram Sang <[email protected]>
>
> Reviewed-by: Geert Uytterhoeven <[email protected]>
> i.e. will queue in renesas-devel for v6.5.
>
> > --- a/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a779a0.dtsi
> > @@ -1108,6 +1108,56 @@ msiof5: spi@e6c28000 {
> > status = "disabled";
> > };
> >
> > + pwm0: pwm@e6e30000 {
>
> I'll move this before serial@e6e60000 while applying, to preserve sort
> order (by unit address).
I still wonder when we can have nice tools that will sort DT and format
DT files for us!
Reviewed-by: Kieran Bingham <[email protected]>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds