2023-05-08 07:12:40

by Siddharth Vadapalli

Subject: [PATCH net-next] net: phy: dp83869: support mii mode when rgmii strap cfg is used

From: Grygorii Strashko <[email protected]>

The DP83869 PHY on TI's k3-am642-evm supports both MII and RGMII
interfaces and is configured by default to use RGMII interface (strap).
However, the board design allows switching dynamically to MII interface
for testing purposes by applying different set of pinmuxes.

To support switching to MII interface, update the DP83869 PHY driver to
configure OP_MODE_DECODE.RGMII_MII_SEL(bit 5) properly when MII PHY
interface mode is requested.

Signed-off-by: Grygorii Strashko <[email protected]>
Signed-off-by: Siddharth Vadapalli <[email protected]>
---

RFC patch at:
https://lore.kernel.org/r/[email protected]/

Changes since RFC patch:
- Change patch subject to PATCH net-next.
- Reword commit message to indicate that the patch adds new support and
is not intended to be a bug fix.
- Add check to ensure that MII mode is requested only with valid operational
modes.


drivers/net/phy/dp83869.c | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
index 9ab5eff502b7..fa8c6fdcf301 100644
--- a/drivers/net/phy/dp83869.c
+++ b/drivers/net/phy/dp83869.c
@@ -692,8 +692,19 @@ static int dp83869_configure_mode(struct phy_device *phydev,
/* Below init sequence for each operational mode is defined in
* section 9.4.8 of the datasheet.
*/
+ phy_ctrl_val = dp83869->mode;
+ if (phydev->interface == PHY_INTERFACE_MODE_MII) {
+ if (dp83869->mode == DP83869_100M_MEDIA_CONVERT ||
+ dp83869->mode == DP83869_RGMII_100_BASE) {
+ phy_ctrl_val |= DP83869_OP_MODE_MII;
+ } else {
+ phydev_err(phydev, "selected op-mode is not valid with MII mode\n");
+ return -EINVAL;
+ }
+ }
+
ret = phy_write_mmd(phydev, DP83869_DEVADDR, DP83869_OP_MODE,
- dp83869->mode);
+ phy_ctrl_val);
if (ret)
return ret;

--
2.25.1

2023-05-09 02:25:17

by Andrew Lunn

Subject: Re: [PATCH net-next] net: phy: dp83869: support mii mode when rgmii strap cfg is used

On Mon, May 08, 2023 at 12:33:59PM +0530, Siddharth Vadapalli wrote:
> From: Grygorii Strashko <[email protected]>
>
> The DP83869 PHY on TI's k3-am642-evm supports both MII and RGMII
> interfaces and is configured by default to use RGMII interface (strap).
> However, the board design allows switching dynamically to MII interface
> for testing purposes by applying different set of pinmuxes.
>
> To support switching to MII interface, update the DP83869 PHY driver to
> configure OP_MODE_DECODE.RGMII_MII_SEL(bit 5) properly when MII PHY
> interface mode is requested.
>
> Signed-off-by: Grygorii Strashko <[email protected]>
> Signed-off-by: Siddharth Vadapalli <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-05-09 11:01:52

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next] net: phy: dp83869: support mii mode when rgmii strap cfg is used

Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <[email protected]>:

On Mon, 8 May 2023 12:33:59 +0530 you wrote:
> From: Grygorii Strashko <[email protected]>
>
> The DP83869 PHY on TI's k3-am642-evm supports both MII and RGMII
> interfaces and is configured by default to use RGMII interface (strap).
> However, the board design allows switching dynamically to MII interface
> for testing purposes by applying different set of pinmuxes.
>
> [...]

Here is the summary with links:
- [net-next] net: phy: dp83869: support mii mode when rgmii strap cfg is used
https://git.kernel.org/netdev/net-next/c/94e86ef1b801

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html