2023-05-04 12:18:30

by Alexandre Ghiti

Subject: [PATCH -fixes] riscv: Fix orphan section warnings caused by kernel/pi

kernel/pi gives rise to a lot of new sections that end up orphans: the
first attempt to fix that tried to enumerate them all in the linker
script, but kernel test robot with a random config keeps finding more of
them.

So prefix all those sections with .init.pi instead of only .init in
order to be able to easily catch them all in the linker script.

Reported-by: kernel test robot <[email protected]>
Link: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 26e7aacb83df ("riscv: Allow to downgrade paging mode from the command line")
Signed-off-by: Alexandre Ghiti <[email protected]>
---
arch/riscv/kernel/pi/Makefile | 2 +-
arch/riscv/kernel/vmlinux.lds.S | 7 ++-----
2 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/arch/riscv/kernel/pi/Makefile b/arch/riscv/kernel/pi/Makefile
index 741b7bd3a84c..07915dc9279e 100644
--- a/arch/riscv/kernel/pi/Makefile
+++ b/arch/riscv/kernel/pi/Makefile
@@ -22,7 +22,7 @@ KCOV_INSTRUMENT := n

$(obj)/%.pi.o: OBJCOPYFLAGS := --prefix-symbols=__pi_ \
--remove-section=.note.gnu.property \
- --prefix-alloc-sections=.init
+ --prefix-alloc-sections=.init.pi
$(obj)/%.pi.o: $(obj)/%.o FORCE
$(call if_changed,objcopy)

diff --git a/arch/riscv/kernel/vmlinux.lds.S b/arch/riscv/kernel/vmlinux.lds.S
index 305877d85e96..e66e26640f63 100644
--- a/arch/riscv/kernel/vmlinux.lds.S
+++ b/arch/riscv/kernel/vmlinux.lds.S
@@ -84,11 +84,8 @@ SECTIONS
__init_data_begin = .;
INIT_DATA_SECTION(16)

- /* Those sections result from the compilation of kernel/pi/string.c */
- .init.pidata : {
- *(.init.srodata.cst8*)
- *(.init__bug_table*)
- *(.init.sdata*)
+ .init.pi : {
+ *(.init.pi*)
}

.init.bss : {
--
2.37.2

2023-05-10 18:54:17

by Palmer Dabbelt

Subject: Re: [PATCH -fixes] riscv: Fix orphan section warnings caused by kernel/pi

On Thu, 04 May 2023 14:07:59 +0200, Alexandre Ghiti wrote:
> kernel/pi gives rise to a lot of new sections that end up orphans: the
> first attempt to fix that tried to enumerate them all in the linker
> script, but kernel test robot with a random config keeps finding more of
> them.
>
> So prefix all those sections with .init.pi instead of only .init in
> order to be able to easily catch them all in the linker script.
>
> [...]

Applied, thanks!

[1/1] riscv: Fix orphan section warnings caused by kernel/pi
https://git.kernel.org/palmer/c/3b90b09af5be

Best regards,
--
Palmer Dabbelt <[email protected]>

2023-05-10 18:59:00

by patchwork-bot+linux-riscv

Subject: Re: [PATCH -fixes] riscv: Fix orphan section warnings caused by kernel/pi

Hello:

This patch was applied to riscv/linux.git (fixes)
by Palmer Dabbelt <[email protected]>:

On Thu, 4 May 2023 14:07:59 +0200 you wrote:
> kernel/pi gives rise to a lot of new sections that end up orphans: the
> first attempt to fix that tried to enumerate them all in the linker
> script, but kernel test robot with a random config keeps finding more of
> them.
>
> So prefix all those sections with .init.pi instead of only .init in
> order to be able to easily catch them all in the linker script.
>
> [...]

Here is the summary with links:
- [-fixes] riscv: Fix orphan section warnings caused by kernel/pi
https://git.kernel.org/riscv/c/3b90b09af5be

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html