2023-05-17 04:34:25

by Chao Yu

Subject: [PATCH v2] f2fs: compress: fix to check validity of i_compress_flag field

The last valid compress related field is i_compress_flag, check its
validity instead of i_log_cluster_size.

Signed-off-by: Chao Yu <[email protected]>
---
v2:
- rebase the code.
fs/f2fs/inode.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index f8bf75c1eca9..0a1748444329 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -361,7 +361,7 @@ static bool sanity_check_inode(struct inode *inode, struct page *node_page)
if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) &&
fi->i_flags & F2FS_COMPR_FL &&
F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
- i_log_cluster_size))
+ i_compress_flag))
return sanity_check_compress_inode(inode, ri);

return true;
@@ -490,7 +490,7 @@ static int do_read_inode(struct inode *inode)
if (f2fs_has_extra_attr(inode) && f2fs_sb_has_compression(sbi) &&
(fi->i_flags & F2FS_COMPR_FL)) {
if (F2FS_FITS_IN_INODE(ri, fi->i_extra_isize,
- i_log_cluster_size)) {
+ i_compress_flag)) {
unsigned short compress_flag;

atomic_set(&fi->i_compr_blocks,
@@ -728,7 +728,7 @@ void f2fs_update_inode(struct inode *inode, struct page *node_page)

if (f2fs_sb_has_compression(F2FS_I_SB(inode)) &&
F2FS_FITS_IN_INODE(ri, F2FS_I(inode)->i_extra_isize,
- i_log_cluster_size)) {
+ i_compress_flag)) {
unsigned short compress_flag;

ri->i_compr_blocks =
--
2.40.1

2023-05-18 01:57:11

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH v2] f2fs: compress: fix to check validity of i_compress_flag field

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Wed, 17 May 2023 11:41:39 +0800 you wrote:
> The last valid compress related field is i_compress_flag, check its
> validity instead of i_log_cluster_size.
>
> Signed-off-by: Chao Yu <[email protected]>
> ---
> v2:
> - rebase the code.
> fs/f2fs/inode.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)

Here is the summary with links:
- [f2fs-dev,v2] f2fs: compress: fix to check validity of i_compress_flag field
https://git.kernel.org/jaegeuk/f2fs/c/8a0dbd506b6d

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html