2023-05-05 19:32:20

by Jaegeuk Kim

Subject: [PATCH] f2fs: fix the wrong condition to determine atomic context

Should use !in_task for irq context.

Fixes: 1aa161e43106 ("f2fs: fix scheduling while atomic in decompression path")
Signed-off-by: Jaegeuk Kim <[email protected]>
---
fs/f2fs/compress.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/f2fs/compress.c b/fs/f2fs/compress.c
index 11653fa79289..10b545a1088e 100644
--- a/fs/f2fs/compress.c
+++ b/fs/f2fs/compress.c
@@ -743,7 +743,7 @@ void f2fs_decompress_cluster(struct decompress_io_ctx *dic, bool in_task)
ret = -EFSCORRUPTED;

/* Avoid f2fs_commit_super in irq context */
- if (in_task)
+ if (!in_task)
f2fs_save_errors(sbi, ERROR_FAIL_DECOMPRESSION);
else
f2fs_handle_error(sbi, ERROR_FAIL_DECOMPRESSION);
--
2.40.1.521.gf1e218fcd8-goog

2023-05-17 02:00:50

by Chao Yu

Subject: Re: [f2fs-dev] [PATCH] f2fs: fix the wrong condition to determine atomic context

On 2023/5/6 3:18, Jaegeuk Kim wrote:
> Should use !in_task for irq context.
>
> Fixes: 1aa161e43106 ("f2fs: fix scheduling while atomic in decompression path")
> Signed-off-by: Jaegeuk Kim <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-05-18 01:56:34

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: fix the wrong condition to determine atomic context

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Fri, 5 May 2023 12:18:41 -0700 you wrote:
> Should use !in_task for irq context.
>
> Fixes: 1aa161e43106 ("f2fs: fix scheduling while atomic in decompression path")
> Signed-off-by: Jaegeuk Kim <[email protected]>
> ---
> fs/f2fs/compress.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- [f2fs-dev] f2fs: fix the wrong condition to determine atomic context
https://git.kernel.org/jaegeuk/f2fs/c/f063fa439956

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html