2023-04-17 17:54:36

by Christian Marangi

[permalink] [raw]
Subject: [PATCH 1/2] clk: qcom: gcc-ipq6018: drop redundant F define

The same exact F frequency table entry is defined in clk-rcg.h
Drop the redundant define to cleanup code.

Signed-off-by: Christian Marangi <[email protected]>
---
drivers/clk/qcom/gcc-ipq6018.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
index 3f9c2f61a5d9..350ead66914c 100644
--- a/drivers/clk/qcom/gcc-ipq6018.c
+++ b/drivers/clk/qcom/gcc-ipq6018.c
@@ -26,8 +26,6 @@
#include "clk-regmap-mux.h"
#include "reset.h"

-#define F(f, s, h, m, n) { (f), (s), (2 * (h) - 1), (m), (n) }
-
enum {
P_XO,
P_BIAS_PLL,
--
2.39.2


2023-04-17 18:05:28

by Christian Marangi

[permalink] [raw]
Subject: [PATCH 2/2] clk: qcom: gcc-sdm660: drop redundant F define

The same exact F frequency table entry is defined in clk-rcg.h
Drop the redundant define to cleanup code.

Signed-off-by: Christian Marangi <[email protected]>
---
drivers/clk/qcom/gcc-sdm660.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sdm660.c b/drivers/clk/qcom/gcc-sdm660.c
index db918c92a522..6afce8e42ede 100644
--- a/drivers/clk/qcom/gcc-sdm660.c
+++ b/drivers/clk/qcom/gcc-sdm660.c
@@ -25,8 +25,6 @@
#include "reset.h"
#include "gdsc.h"

-#define F(f, s, h, m, n) { (f), (s), (2 * (h) - 1), (m), (n) }
-
enum {
P_XO,
P_SLEEP_CLK,
--
2.39.2

2023-04-17 18:06:11

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/2] clk: qcom: gcc-ipq6018: drop redundant F define



On 17.04.2023 19:44, Christian Marangi wrote:
> The same exact F frequency table entry is defined in clk-rcg.h
> Drop the redundant define to cleanup code.
>
> Signed-off-by: Christian Marangi <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/clk/qcom/gcc-ipq6018.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/clk/qcom/gcc-ipq6018.c b/drivers/clk/qcom/gcc-ipq6018.c
> index 3f9c2f61a5d9..350ead66914c 100644
> --- a/drivers/clk/qcom/gcc-ipq6018.c
> +++ b/drivers/clk/qcom/gcc-ipq6018.c
> @@ -26,8 +26,6 @@
> #include "clk-regmap-mux.h"
> #include "reset.h"
>
> -#define F(f, s, h, m, n) { (f), (s), (2 * (h) - 1), (m), (n) }
> -
> enum {
> P_XO,
> P_BIAS_PLL,

2023-05-25 04:52:25

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] clk: qcom: gcc-ipq6018: drop redundant F define

On Mon, 17 Apr 2023 19:44:07 +0200, Christian Marangi wrote:
> The same exact F frequency table entry is defined in clk-rcg.h
> Drop the redundant define to cleanup code.
>
>

Applied, thanks!

[1/2] clk: qcom: gcc-ipq6018: drop redundant F define
commit: 923f7d678b2ae3d522543058514d5605c185633b
[2/2] clk: qcom: gcc-sdm660: drop redundant F define
commit: bbd899f53412b79cbc46e7144437bb75302b1b80

Best regards,
--
Bjorn Andersson <[email protected]>