2023-05-18 17:50:24

by Rohit Agarwal

[permalink] [raw]
Subject: [PATCH v6 0/5] Add PCIe EP support for SDX65

Hi,

Changes in v6:
- Rebased on top of 6.4-rc2.

Changes in v5:
- Addressed some minor comments from Konrad
- Rebased on top of 6.3-rc5.

Changes in v4:
- Addressed comment from Dmitry to move the gpios to the board file.

Changes in v3:
- Removing the applied patch.
- Addressing some of the compile time issues missed in v2.

Changes in v2:
- Addressing comments from Konrad and Dmitry.
- Rebased on top of 6.3-rc1.

This series adds the devicetree support for PCIe PHY and PCIe EP on SDX65.
The PCIe EP is enabled on SDX65 MTP board.

Thanks,
Rohit.

Rohit Agarwal (5):
dt-bindings: PCI: qcom: Add SDX65 SoC
ARM: dts: qcom: sdx65: Add support for PCIe PHY
ARM: dts: qcom: sdx65: Add support for PCIe EP
ARM: dts: qcom: sdx65-mtp: Enable PCIe PHY
ARM: dts: qcom: sdx65-mtp: Enable PCIe EP

.../devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 +
arch/arm/boot/dts/qcom-sdx65-mtp.dts | 42 +++++++++++
arch/arm/boot/dts/qcom-sdx65.dtsi | 87 ++++++++++++++++++++++
3 files changed, 131 insertions(+)

--
2.7.4



2023-05-18 17:56:33

by Rohit Agarwal

[permalink] [raw]
Subject: [PATCH v6 1/5] dt-bindings: PCI: qcom: Add SDX65 SoC

Add PCIe EP compatible string for SDX65 SoC.

Signed-off-by: Rohit Agarwal <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
Reviewed-by: Manivannan Sadhasivam <[email protected]>
---
Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
index b3c22eb..8111122 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
@@ -13,6 +13,7 @@ properties:
compatible:
enum:
- qcom,sdx55-pcie-ep
+ - qcom,sdx65-pcie-ep
- qcom,sm8450-pcie-ep

reg:
@@ -109,6 +110,7 @@ allOf:
contains:
enum:
- qcom,sdx55-pcie-ep
+ - qcom,sdx65-pcie-ep
then:
properties:
clocks:
--
2.7.4


2023-05-25 05:43:03

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v6 0/5] Add PCIe EP support for SDX65

On Thu, 18 May 2023 23:17:48 +0530, Rohit Agarwal wrote:
> Changes in v6:
> - Rebased on top of 6.4-rc2.
>
> Changes in v5:
> - Addressed some minor comments from Konrad
> - Rebased on top of 6.3-rc5.
>
> [...]

Applied, thanks!

[1/5] dt-bindings: PCI: qcom: Add SDX65 SoC
(no commit info)
[2/5] ARM: dts: qcom: sdx65: Add support for PCIe PHY
commit: 92543a1ef22d0270425a4dfe8efe4ab30c4a8a5e
[3/5] ARM: dts: qcom: sdx65: Add support for PCIe EP
commit: 91dfb64ba70bab4d3517f4e7cb2e4cc8f5a8f81a
[4/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe PHY
commit: 07bb20f207cb5868a47217681e4843f566843d29
[5/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe EP
commit: e110dea61ff3f35e6d15e8c5009fb0e876a7d8ae

Best regards,
--
Bjorn Andersson <[email protected]>

2023-05-25 05:43:49

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v6 1/5] dt-bindings: PCI: qcom: Add SDX65 SoC

On Thu, May 18, 2023 at 11:17:49PM +0530, Rohit Agarwal wrote:
> Add PCIe EP compatible string for SDX65 SoC.
>
> Signed-off-by: Rohit Agarwal <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> Reviewed-by: Manivannan Sadhasivam <[email protected]>

Bjorn, Lorenzo, please pick this patch through the PCI tree (to avoid
any merge issues).

Thanks,
Bjorn

> ---
> Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> index b3c22eb..8111122 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie-ep.yaml
> @@ -13,6 +13,7 @@ properties:
> compatible:
> enum:
> - qcom,sdx55-pcie-ep
> + - qcom,sdx65-pcie-ep
> - qcom,sm8450-pcie-ep
>
> reg:
> @@ -109,6 +110,7 @@ allOf:
> contains:
> enum:
> - qcom,sdx55-pcie-ep
> + - qcom,sdx65-pcie-ep
> then:
> properties:
> clocks:
> --
> 2.7.4
>

2023-05-25 22:59:39

by Bjorn Helgaas

[permalink] [raw]
Subject: Re: [PATCH v6 0/5] Add PCIe EP support for SDX65

On Wed, May 24, 2023 at 09:54:38PM -0700, Bjorn Andersson wrote:
> On Thu, 18 May 2023 23:17:48 +0530, Rohit Agarwal wrote:
> > Changes in v6:
> > - Rebased on top of 6.4-rc2.
> >
> > Changes in v5:
> > - Addressed some minor comments from Konrad
> > - Rebased on top of 6.3-rc5.
> >
> > [...]
>
> Applied, thanks!
>
> [1/5] dt-bindings: PCI: qcom: Add SDX65 SoC
> (no commit info)

For clarification, I guess this means you did *not* apply [1/5], and
you'd like Lorenzo to apply it?

> [2/5] ARM: dts: qcom: sdx65: Add support for PCIe PHY
> commit: 92543a1ef22d0270425a4dfe8efe4ab30c4a8a5e
> [3/5] ARM: dts: qcom: sdx65: Add support for PCIe EP
> commit: 91dfb64ba70bab4d3517f4e7cb2e4cc8f5a8f81a
> [4/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe PHY
> commit: 07bb20f207cb5868a47217681e4843f566843d29
> [5/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe EP
> commit: e110dea61ff3f35e6d15e8c5009fb0e876a7d8ae

2023-05-25 23:01:06

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v6 0/5] Add PCIe EP support for SDX65

On Thu, May 25, 2023 at 05:13:27PM -0500, Bjorn Helgaas wrote:
> On Wed, May 24, 2023 at 09:54:38PM -0700, Bjorn Andersson wrote:
> > On Thu, 18 May 2023 23:17:48 +0530, Rohit Agarwal wrote:
> > > Changes in v6:
> > > - Rebased on top of 6.4-rc2.
> > >
> > > Changes in v5:
> > > - Addressed some minor comments from Konrad
> > > - Rebased on top of 6.3-rc5.
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/5] dt-bindings: PCI: qcom: Add SDX65 SoC
> > (no commit info)
>
> For clarification, I guess this means you did *not* apply [1/5], and
> you'd like Lorenzo to apply it?
>

That is correct, sorry for the confusion.

Thanks,
Bjorn

> > [2/5] ARM: dts: qcom: sdx65: Add support for PCIe PHY
> > commit: 92543a1ef22d0270425a4dfe8efe4ab30c4a8a5e
> > [3/5] ARM: dts: qcom: sdx65: Add support for PCIe EP
> > commit: 91dfb64ba70bab4d3517f4e7cb2e4cc8f5a8f81a
> > [4/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe PHY
> > commit: 07bb20f207cb5868a47217681e4843f566843d29
> > [5/5] ARM: dts: qcom: sdx65-mtp: Enable PCIe EP
> > commit: e110dea61ff3f35e6d15e8c5009fb0e876a7d8ae