2023-05-23 21:55:51

by Mark Brown

[permalink] [raw]
Subject: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature

The newly added support for ECV CNTPOFF open codes the recently added
helper ARM64_CPUID_FIELDS(), make use of the helper. No functional
change.

Signed-off-by: Mark Brown <[email protected]>
---
arch/arm64/kernel/cpufeature.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
index 7d7128c65161..27326f35b646 100644
--- a/arch/arm64/kernel/cpufeature.c
+++ b/arch/arm64/kernel/cpufeature.c
@@ -2235,11 +2235,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
.capability = ARM64_HAS_ECV_CNTPOFF,
.type = ARM64_CPUCAP_SYSTEM_FEATURE,
.matches = has_cpuid_feature,
- .sys_reg = SYS_ID_AA64MMFR0_EL1,
- .field_pos = ID_AA64MMFR0_EL1_ECV_SHIFT,
- .field_width = 4,
- .sign = FTR_UNSIGNED,
- .min_field_value = ID_AA64MMFR0_EL1_ECV_CNTPOFF,
+ ARM64_CPUID_FIELDS(ID_AA64MMFR0_EL1, ECV, CNTPOFF)
},
#ifdef CONFIG_ARM64_PAN
{

---
base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
change-id: 20230523-arm64-ecv-helper-c1665690b8b0

Best regards,
--
Mark Brown <[email protected]>



2023-05-25 08:57:17

by Anshuman Khandual

[permalink] [raw]
Subject: Re: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature



On 5/24/23 03:19, Mark Brown wrote:
> The newly added support for ECV CNTPOFF open codes the recently added
> helper ARM64_CPUID_FIELDS(), make use of the helper. No functional
> change.
>
> Signed-off-by: Mark Brown <[email protected]>

Reviewed-by: Anshuman Khandual <[email protected]>

> ---
> arch/arm64/kernel/cpufeature.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c
> index 7d7128c65161..27326f35b646 100644
> --- a/arch/arm64/kernel/cpufeature.c
> +++ b/arch/arm64/kernel/cpufeature.c
> @@ -2235,11 +2235,7 @@ static const struct arm64_cpu_capabilities arm64_features[] = {
> .capability = ARM64_HAS_ECV_CNTPOFF,
> .type = ARM64_CPUCAP_SYSTEM_FEATURE,
> .matches = has_cpuid_feature,
> - .sys_reg = SYS_ID_AA64MMFR0_EL1,
> - .field_pos = ID_AA64MMFR0_EL1_ECV_SHIFT,
> - .field_width = 4,
> - .sign = FTR_UNSIGNED,
> - .min_field_value = ID_AA64MMFR0_EL1_ECV_CNTPOFF,
> + ARM64_CPUID_FIELDS(ID_AA64MMFR0_EL1, ECV, CNTPOFF)
> },
> #ifdef CONFIG_ARM64_PAN
> {
>
> ---
> base-commit: 44c026a73be8038f03dbdeef028b642880cf1511
> change-id: 20230523-arm64-ecv-helper-c1665690b8b0
>
> Best regards,

2023-05-26 09:47:48

by Catalin Marinas

[permalink] [raw]
Subject: Re: [PATCH] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature

On Tue, 23 May 2023 22:49:00 +0100, Mark Brown wrote:
> The newly added support for ECV CNTPOFF open codes the recently added
> helper ARM64_CPUID_FIELDS(), make use of the helper. No functional
> change.
>
>

Applied to arm64 (for-next/misc), thanks!

[1/1] arm64/cpufeature: Use helper for ECV CNTPOFF cpufeature
https://git.kernel.org/arm64/c/e34f78b970ea

--
Catalin