Changes since v10:
-----------------
- v10 can be seen here: https://lore.kernel.org/lkml/[email protected]/
- Rebased on phy/next, as Vinod was seeing rebasing issues with v9 while
applying.
Changes since v9:
-----------------
- v9 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed review comments from Dmitry on v9, regarding register size
and pcs_misc offset handling. Also collected his R-Bs.
Changes since v8:
-----------------
- v8 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Added driver change for new bindings used for sm6115 / qcm2290
devices.
Changes since v7:
-----------------
- v7 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed review comments from Dmitry and added "pipe clk".
Changes since v6:
-----------------
- v6 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed review comments from Bjorn and Dmitry and dropped old bindings in this
version.
Changes since v5:
-----------------
- v5 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Addressed review comments from Dmitry and made [PATCH 1/2] compatible with his
'split away legacy USB+DP code' series:
<https://patchwork.kernel.org/project/linux-phy/cover/[email protected]>
Changes since v4:
-----------------
- v4 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Collected Krzysztof's Ack for [PATCH 1/2].
- Added more descriptive commit logs as per Dmitry's comments on v4.
Changes since v3:
-----------------
- v3 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
- Fixed v4 as per the downstream driver code: https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296
This patchset adds the support for USB SS qmp phy for Qualcomm SM6115
SoC. For the previous versions of this patch there were conversations
on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a
'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware
documentation.
But after a careful look at downstream dtsi (see [1]) it appears that
this indeed is a 'qcom,usb-ssphy-qmp-usb3-or-dp' phy and not a
'dp-combo' phy.
[1]. https://android.googlesource.com/kernel/msm-extra/devicetree/+/refs/heads/android-msm-bramble-4.19-android11-qpr1/qcom/bengal-usb.dtsi#296
Bhupesh Sharma (4):
dt-bindings: phy: qcom,qmp-usb: Drop legacy bindings and move to newer
one (SM6115 & QCM2290)
phy: qcom-qmp-usb: add support for updated qcm2290 / sm6115 binding
arm64: dts: qcom: sm6115: Add USB SS qmp phy node
arm64: dts: qcom: qrb4210-rb2: Enable USB node
.../phy/qcom,msm8996-qmp-usb3-phy.yaml | 27 -------------
.../phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml | 38 +++++++++++++++++++
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 24 ++++++++++++
.../boot/dts/qcom/sm4250-oneplus-billie2.dts | 3 ++
arch/arm64/boot/dts/qcom/sm6115.dtsi | 29 +++++++++++++-
.../boot/dts/qcom/sm6115p-lenovo-j606f.dts | 3 ++
drivers/phy/qualcomm/phy-qcom-qmp-usb.c | 22 +++++++++++
7 files changed, 117 insertions(+), 29 deletions(-)
--
2.38.1
Enable the USB controller and HS/SS PHYs on qrb4210-rb2 board.
Reviewed-by: Dmitry Baryshkov <[email protected]>
Signed-off-by: Bhupesh Sharma <[email protected]>
---
arch/arm64/boot/dts/qcom/qrb4210-rb2.dts | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
index dc80f0bca767..eae3024ce003 100644
--- a/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
+++ b/arch/arm64/boot/dts/qcom/qrb4210-rb2.dts
@@ -222,6 +222,30 @@ &uart4 {
status = "okay";
};
+&usb {
+ status = "okay";
+};
+
+&usb_dwc3 {
+ maximum-speed = "super-speed";
+ dr_mode = "peripheral";
+};
+
+&usb_hsphy {
+ vdd-supply = <&vreg_l4a_0p9>;
+ vdda-pll-supply = <&vreg_l12a_1p8>;
+ vdda-phy-dpdm-supply = <&vreg_l15a_3p128>;
+
+ status = "okay";
+};
+
+&usb_qmpphy {
+ vdda-phy-supply = <&vreg_l4a_0p9>;
+ vdda-pll-supply = <&vreg_l12a_1p8>;
+
+ status = "okay";
+};
+
&xo_board {
clock-frequency = <19200000>;
};
--
2.38.1
On 16-05-23, 20:35, Bhupesh Sharma wrote:
>
> This patchset adds the support for USB SS qmp phy for Qualcomm SM6115
> SoC. For the previous versions of this patch there were conversations
> on irc as to whether this was a 'qcom,usb-ssphy-qmp-usb3-or-dp' or a
> 'qcom,usb-ssphy-qmp-dp-combo' as per downstream code and hardware
> documentation.
Applied patch 1,2
Thanks
--
~Vinod
On Tue, 16 May 2023 20:35:07 +0530, Bhupesh Sharma wrote:
> Changes since v10:
> -----------------
> - v10 can be seen here: https://lore.kernel.org/lkml/[email protected]/
> - Rebased on phy/next, as Vinod was seeing rebasing issues with v9 while
> applying.
>
> Changes since v9:
> -----------------
> - v9 can be seen here: https://lore.kernel.org/linux-arm-msm/[email protected]/
> - Addressed review comments from Dmitry on v9, regarding register size
> and pcs_misc offset handling. Also collected his R-Bs.
>
> [...]
Applied, thanks!
[3/4] arm64: dts: qcom: sm6115: Add USB SS qmp phy node
commit: 9dd5f6dba72928e1f16b259fb1c984f80bfa4120
[4/4] arm64: dts: qcom: qrb4210-rb2: Enable USB node
commit: eaa53a85748d58c4398c5c9acaa8d01d92adbb67
Best regards,
--
Bjorn Andersson <[email protected]>