The default deadline bandwidth control structure has been removed since
commit eb77cf1c151c ("sched/deadline: Remove unused def_dl_bandwidth")
leading to unused init_dl_bandwidth() and struct dl_bandwidth. Remove
them to clean up the code.
Signed-off-by: Miaohe Lin <[email protected]>
---
kernel/sched/deadline.c | 7 -------
kernel/sched/sched.h | 7 -------
2 files changed, 14 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index fe983ed7bb12..7c98ca1f7300 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -482,13 +482,6 @@ static inline int is_leftmost(struct task_struct *p, struct dl_rq *dl_rq)
static void init_dl_rq_bw_ratio(struct dl_rq *dl_rq);
-void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime)
-{
- raw_spin_lock_init(&dl_b->dl_runtime_lock);
- dl_b->dl_period = period;
- dl_b->dl_runtime = runtime;
-}
-
void init_dl_bw(struct dl_bw *dl_b)
{
raw_spin_lock_init(&dl_b->lock);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 1704763897d0..d79f4fd53600 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -286,12 +286,6 @@ struct rt_bandwidth {
void __dl_clear_params(struct task_struct *p);
-struct dl_bandwidth {
- raw_spinlock_t dl_runtime_lock;
- u64 dl_runtime;
- u64 dl_period;
-};
-
static inline int dl_bandwidth_enabled(void)
{
return sysctl_sched_rt_runtime >= 0;
@@ -2394,7 +2388,6 @@ extern struct rt_bandwidth def_rt_bandwidth;
extern void init_rt_bandwidth(struct rt_bandwidth *rt_b, u64 period, u64 runtime);
extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
-extern void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime);
extern void init_dl_task_timer(struct sched_dl_entity *dl_se);
extern void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se);
--
2.27.0
On 24/05/23 18:25, Miaohe Lin wrote:
> The default deadline bandwidth control structure has been removed since
> commit eb77cf1c151c ("sched/deadline: Remove unused def_dl_bandwidth")
> leading to unused init_dl_bandwidth() and struct dl_bandwidth. Remove
> them to clean up the code.
>
> Signed-off-by: Miaohe Lin <[email protected]>
Ah, indeed.
Acked-by: Juri Lelli <[email protected]>
Thanks!
Juri
On 5/24/23 12:25, Miaohe Lin wrote:
> The default deadline bandwidth control structure has been removed since
> commit eb77cf1c151c ("sched/deadline: Remove unused def_dl_bandwidth")
> leading to unused init_dl_bandwidth() and struct dl_bandwidth. Remove
> them to clean up the code.
I wondered if it desire a Fixes tags... Anyways, it is just dead code.
> Signed-off-by: Miaohe Lin <[email protected]>
Reviewed-by: Daniel Bristot de Oliveira <[email protected]>
Thanks!
-- Daniel
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 3f4bf7aa315bf55b2a569bf77f61ff81c7e11fc1
Gitweb: https://git.kernel.org/tip/3f4bf7aa315bf55b2a569bf77f61ff81c7e11fc1
Author: Miaohe Lin <[email protected]>
AuthorDate: Wed, 24 May 2023 18:25:14 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Tue, 30 May 2023 22:46:26 +02:00
sched/deadline: remove unused dl_bandwidth
The default deadline bandwidth control structure has been removed since
commit eb77cf1c151c ("sched/deadline: Remove unused def_dl_bandwidth")
leading to unused init_dl_bandwidth() and struct dl_bandwidth. Remove
them to clean up the code.
Signed-off-by: Miaohe Lin <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Acked-by: Juri Lelli <[email protected]>
Link: https://lore.kernel.org/r/[email protected]
---
kernel/sched/deadline.c | 7 -------
kernel/sched/sched.h | 7 -------
2 files changed, 14 deletions(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 5a9a4b8..f827067 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -489,13 +489,6 @@ static inline int is_leftmost(struct task_struct *p, struct dl_rq *dl_rq)
static void init_dl_rq_bw_ratio(struct dl_rq *dl_rq);
-void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime)
-{
- raw_spin_lock_init(&dl_b->dl_runtime_lock);
- dl_b->dl_period = period;
- dl_b->dl_runtime = runtime;
-}
-
void init_dl_bw(struct dl_bw *dl_b)
{
raw_spin_lock_init(&dl_b->lock);
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 6784462..d8ba81c 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -286,12 +286,6 @@ struct rt_bandwidth {
void __dl_clear_params(struct task_struct *p);
-struct dl_bandwidth {
- raw_spinlock_t dl_runtime_lock;
- u64 dl_runtime;
- u64 dl_period;
-};
-
static inline int dl_bandwidth_enabled(void)
{
return sysctl_sched_rt_runtime >= 0;
@@ -2394,7 +2388,6 @@ extern struct rt_bandwidth def_rt_bandwidth;
extern void init_rt_bandwidth(struct rt_bandwidth *rt_b, u64 period, u64 runtime);
extern bool sched_rt_bandwidth_account(struct rt_rq *rt_rq);
-extern void init_dl_bandwidth(struct dl_bandwidth *dl_b, u64 period, u64 runtime);
extern void init_dl_task_timer(struct sched_dl_entity *dl_se);
extern void init_dl_inactive_task_timer(struct sched_dl_entity *dl_se);