2023-05-15 19:00:33

by Andrew Davis

[permalink] [raw]
Subject: [PATCH 1/5] ARM: keystone: Merge memory.h into the only file that uses it

The defines in memory.h can go into the file that makes use of them.
No reason to have a header here, remove.

Signed-off-by: Andrew Davis <[email protected]>
---
arch/arm/mach-keystone/keystone.c | 12 ++++++++++--
arch/arm/mach-keystone/memory.h | 18 ------------------
2 files changed, 10 insertions(+), 20 deletions(-)
delete mode 100644 arch/arm/mach-keystone/memory.h

diff --git a/arch/arm/mach-keystone/keystone.c b/arch/arm/mach-keystone/keystone.c
index aa352c2de313..fdc7d3621bd0 100644
--- a/arch/arm/mach-keystone/keystone.c
+++ b/arch/arm/mach-keystone/keystone.c
@@ -20,10 +20,18 @@
#include <asm/mach/time.h>
#include <asm/memory.h>

-#include "memory.h"
-
#include "keystone.h"

+#define KEYSTONE_LOW_PHYS_START 0x80000000ULL
+#define KEYSTONE_LOW_PHYS_SIZE 0x80000000ULL /* 2G */
+#define KEYSTONE_LOW_PHYS_END (KEYSTONE_LOW_PHYS_START + \
+ KEYSTONE_LOW_PHYS_SIZE - 1)
+
+#define KEYSTONE_HIGH_PHYS_START 0x800000000ULL
+#define KEYSTONE_HIGH_PHYS_SIZE 0x400000000ULL /* 16G */
+#define KEYSTONE_HIGH_PHYS_END (KEYSTONE_HIGH_PHYS_START + \
+ KEYSTONE_HIGH_PHYS_SIZE - 1)
+
#ifdef CONFIG_ARM_LPAE
static int keystone_platform_notifier(struct notifier_block *nb,
unsigned long event, void *data)
diff --git a/arch/arm/mach-keystone/memory.h b/arch/arm/mach-keystone/memory.h
deleted file mode 100644
index 1b9ed1271e05..000000000000
--- a/arch/arm/mach-keystone/memory.h
+++ /dev/null
@@ -1,18 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0-only */
-/*
- * Copyright 2014 Texas Instruments, Inc.
- * Santosh Shilimkar <[email protected]>
- */
-#ifndef __MEMORY_H
-#define __MEMORY_H
-
-#define KEYSTONE_LOW_PHYS_START 0x80000000ULL
-#define KEYSTONE_LOW_PHYS_SIZE 0x80000000ULL /* 2G */
-#define KEYSTONE_LOW_PHYS_END (KEYSTONE_LOW_PHYS_START + \
- KEYSTONE_LOW_PHYS_SIZE - 1)
-
-#define KEYSTONE_HIGH_PHYS_START 0x800000000ULL
-#define KEYSTONE_HIGH_PHYS_SIZE 0x400000000ULL /* 16G */
-#define KEYSTONE_HIGH_PHYS_END (KEYSTONE_HIGH_PHYS_START + \
- KEYSTONE_HIGH_PHYS_SIZE - 1)
-#endif /* __MEMORY_H */
--
2.39.2



2023-06-07 18:37:48

by Nishanth Menon

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/5] ARM: keystone: Merge memory.h into the only file that uses it

Hi Andrew Davis,

On Mon, 15 May 2023 13:35:11 -0500, Andrew Davis wrote:
> The defines in memory.h can go into the file that makes use of them.
> No reason to have a header here, remove.
>
>

I have applied the following to branch ti-keystone-dts-next on [1].
Thank you!

[3/5] ARM: dts: keystone: Fix EEPROM node names
commit: 5ae8afd41ea5a1767d0b683ffa8f9ff3d9c7e68c
[4/5] ARM: dts: keystone: Remove ti,keystone from soc node compatible
commit: 4b3498372664efe3755255402537e243bc83eb82
[5/5] ARM: dts: keystone: Do not capitalize hex digits
commit: 2d62aab57d2ace03d840c08fb323ed1b9bd83a94

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] git://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D