2023-06-06 06:27:19

by Chao Yu

Subject: [PATCH] f2fs: check return value of freeze_super()

freeze_super() can fail, it needs to check its return value and do
error handling in f2fs_resize_fs().

Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS")
Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress")
Signed-off-by: Chao Yu <[email protected]>
---
fs/f2fs/gc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 8cbe4839f640..de893f4f60e1 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -2271,7 +2271,9 @@ int f2fs_resize_fs(struct file *filp, __u64 block_count)
if (err)
return err;

- freeze_super(sbi->sb);
+ err = freeze_super(sbi->sb);
+ if (err)
+ return err;

if (f2fs_readonly(sbi->sb)) {
thaw_super(sbi->sb);
--
2.40.1

2023-06-12 21:09:53

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: check return value of freeze_super()

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Tue, 6 Jun 2023 14:19:01 +0800 you wrote:
> freeze_super() can fail, it needs to check its return value and do
> error handling in f2fs_resize_fs().
>
> Fixes: 04f0b2eaa3b3 ("f2fs: ioctl for removing a range from F2FS")
> Fixes: b4b10061ef98 ("f2fs: refactor resize_fs to avoid meta updates in progress")
> Signed-off-by: Chao Yu <[email protected]>
>
> [...]

Here is the summary with links:
- [f2fs-dev] f2fs: check return value of freeze_super()
https://git.kernel.org/jaegeuk/f2fs/c/e6fd55c1f4b6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html