The DisplayPort blocks are powered by MMCX and should be described as
such to ensure that power votes are done on the right resource.
This also solves the problem that sync_state is unaware of the DP
controllers needing MMCX to be kept alive during boot. As such this
change also fixes occasionally seen crashes during boot due to
undervoltage of MMCX.
Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
Signed-off-by: Bjorn Andersson <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index 3de62e26d56a..a7668f9e68d6 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -2969,7 +2969,7 @@ mdss_dp0: displayport-controller@ae90000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&dp0_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
@@ -3043,7 +3043,7 @@ mdss_dp1: displayport-controller@ae98000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&dp0_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
@@ -3117,7 +3117,7 @@ mdss_edp: displayport-controller@ae9a000 {
#sound-dai-cells = <0>;
operating-points-v2 = <&edp_opp_table>;
- power-domains = <&rpmhpd SC8180X_CX>;
+ power-domains = <&rpmhpd SC8180X_MMCX>;
status = "disabled";
--
2.25.1
On 13/06/2023 01:07, Bjorn Andersson wrote:
> The DisplayPort blocks are powered by MMCX and should be described as
> such to ensure that power votes are done on the right resource.
>
> This also solves the problem that sync_state is unaware of the DP
> controllers needing MMCX to be kept alive during boot. As such this
> change also fixes occasionally seen crashes during boot due to
> undervoltage of MMCX.
>
> Fixes: 494dec9b6f54 ("arm64: dts: qcom: sc8180x: Add display and gpu nodes")
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Dmitry Baryshkov <[email protected]>
--
With best wishes
Dmitry
On Mon, 12 Jun 2023 15:07:39 -0700, Bjorn Andersson wrote:
> The DisplayPort blocks are powered by MMCX and should be described as
> such to ensure that power votes are done on the right resource.
>
> This also solves the problem that sync_state is unaware of the DP
> controllers needing MMCX to be kept alive during boot. As such this
> change also fixes occasionally seen crashes during boot due to
> undervoltage of MMCX.
>
> [...]
Applied, thanks!
[1/1] arm64: dts: qcom: sc8180x: Move DisplayPort for MMCX
commit: 2d7b1a31ffb865d1f8e95e985cdbd0df72f671cf
Best regards,
--
Bjorn Andersson <[email protected]>