2023-06-16 13:03:26

by Juerg Haefliger

Subject: [PATCH] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <[email protected]>
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 583daacf3705..6b2a4f8d6f78 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -1019,3 +1019,5 @@ module_i2c_driver(lt9611uxc_driver);

MODULE_AUTHOR("Dmitry Baryshkov <[email protected]>");
MODULE_LICENSE("GPL v2");
+
+MODULE_FIRMWARE("lt9611uxc_fw.bin");
--
2.37.2

2023-06-16 13:54:21

by Robert Foss

Subject: Re: [PATCH] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

On Fri, Jun 16, 2023 at 2:13 PM Juerg Haefliger
<[email protected]> wrote:
>
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <[email protected]>
> ---
> drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> index 583daacf3705..6b2a4f8d6f78 100644
> --- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> +++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
> @@ -1019,3 +1019,5 @@ module_i2c_driver(lt9611uxc_driver);
>
> MODULE_AUTHOR("Dmitry Baryshkov <[email protected]>");
> MODULE_LICENSE("GPL v2");
> +
> +MODULE_FIRMWARE("lt9611uxc_fw.bin");
> --
> 2.37.2
>

Can filename string be made into a macro, as it is used in two locations?

With that fixed, please add my r-b.


Rob.

2023-06-20 06:47:32

by Juerg Haefliger

Subject: [PATCH v2] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

The module loads firmware so add a MODULE_FIRMWARE macro to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <[email protected]>
Reviewed-by: Robert Foss <[email protected]>
---
v2:
- Introduce FW_FILE macro
- Add Rob's r-b
---
drivers/gpu/drm/bridge/lontium-lt9611uxc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
index 2a57e804ea02..22c84d29c2bc 100644
--- a/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
+++ b/drivers/gpu/drm/bridge/lontium-lt9611uxc.c
@@ -28,6 +28,8 @@
#define EDID_BLOCK_SIZE 128
#define EDID_NUM_BLOCKS 2

+#define FW_FILE "lt9611uxc_fw.bin"
+
struct lt9611uxc {
struct device *dev;
struct drm_bridge bridge;
@@ -754,7 +756,7 @@ static int lt9611uxc_firmware_update(struct lt9611uxc *lt9611uxc)
REG_SEQ0(0x805a, 0x00),
};

- ret = request_firmware(&fw, "lt9611uxc_fw.bin", lt9611uxc->dev);
+ ret = request_firmware(&fw, FW_FILE, lt9611uxc->dev);
if (ret < 0)
return ret;

@@ -1019,3 +1021,5 @@ module_i2c_driver(lt9611uxc_driver);

MODULE_AUTHOR("Dmitry Baryshkov <[email protected]>");
MODULE_LICENSE("GPL v2");
+
+MODULE_FIRMWARE(FW_FILE);
--
2.37.2

2023-06-21 13:13:16

by Robert Foss

Subject: Re: [PATCH v2] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro

From: Robert Foss <[email protected]>

On Tue, 20 Jun 2023 08:12:54 +0200, Juerg Haefliger wrote:
> The module loads firmware so add a MODULE_FIRMWARE macro to provide that
> information via modinfo.
>
>

Applied, thanks!

[1/1] drm/bridge: lt9611uxc: Add MODULE_FIRMWARE macro
https://cgit.freedesktop.org/drm/drm-misc/commit/?id=354c0fb61739



Rob