2023-06-27 16:55:48

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 00/11] Even more msm bindings fixes

This series contains couple more random dt schema warning fixes, centered
around linux-msm.

All of the patches (except) the last two are pretty much independent.
Patch 1 is not only a bindings fix, but also a functional one.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Konrad Dybcio (11):
arm64: dts: qcom: sc7180: Fix DSI0_PHY reg-names
arm64: dts: qcom: msm8939: Drop "qcom,idle-state-spc" compatible
arm64: dts: qcom: msm8939: Add missing 'cache-unified' to L2
arm64: dts: qcom: apq8039-t2: Drop inexistent property
dt-bindings: sound: Convert pm8916-wcd-analog-codec to YAML
dt-bindings: mfd: qcom,spmi-pmic: Reference pm8916 wcd analog codec schema
dt-bindings: iommu: qcom_iommu: Allow 'tbu' clock
dt-bindings: usb: ci-hdrc-usb2: Fix handling pinctrl properties
dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
dt-bindings: usb: dwc3: Allow just 1 interrupt for MSM8996
arm64: dts: qcom: msm8996: Add missing interrupt to the USB2 controller

.../devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 +
.../devicetree/bindings/iommu/qcom,iommu.yaml | 4 +
.../devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 2 +-
.../bindings/sound/qcom,msm8916-wcd-analog.txt | 101 -------------
.../sound/qcom,pm8916-wcd-analog-codec.yaml | 160 +++++++++++++++++++++
.../devicetree/bindings/usb/ci-hdrc-usb2.yaml | 27 +---
.../devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
arch/arm64/boot/dts/qcom/apq8039-t2.dts | 1 -
arch/arm64/boot/dts/qcom/msm8939.dtsi | 4 +-
arch/arm64/boot/dts/qcom/msm8996.dtsi | 3 +
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 +-
11 files changed, 182 insertions(+), 127 deletions(-)
---
base-commit: 3eedd211ad93c322fb360b83a3d76a2c6cd622dc
change-id: 20230627-topic-more_bindings-325a6f4b93a7

Best regards,
--
Konrad Dybcio <[email protected]>



2023-06-27 16:57:11

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional

The description of reg[1] says that register is optional. Adjust
minItems to make it truly optional.

Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
index 5e16121d9f0d..75b6287db2c9 100644
--- a/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
+++ b/Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml
@@ -22,6 +22,7 @@ properties:
- qcom,kpss-acc-v2

reg:
+ minItems: 1
items:
- description: Base address and size of the register region
- description: Optional base address and size of the alias register region

--
2.41.0


2023-06-27 16:57:16

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 04/11] arm64: dts: qcom: apq8039-t2: Drop inexistent property

'pin-switch-delay-us' is not used anywhere in the mainline kernel.
Drop it.

Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8039-t2.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
index 43686bbd87f4..027d1da7e81d 100644
--- a/arch/arm64/boot/dts/qcom/apq8039-t2.dts
+++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
@@ -374,7 +374,6 @@ &usb {
pinctrl-0 = <&pinctrl_otg_default>;
pinctrl-1 = <&pinctrl_otg_host>;
pinctrl-2 = <&pinctrl_otg_device>;
- pin-switch-delay-us = <100000>;
usb-role-switch;
status = "okay";


--
2.41.0


2023-06-27 17:01:44

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 01/11] arm64: dts: qcom: sc7180: Fix DSI0_PHY reg-names

Commit 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI
nodes") broke reg-names, possibly with search-and-replace. Fix it.

Fixes: 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI nodes")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 34eff97f8630..b9640574e73b 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -3120,8 +3120,8 @@ mdss_dsi0_phy: phy@ae94400 {
reg = <0 0x0ae94400 0 0x200>,
<0 0x0ae94600 0 0x280>,
<0 0x0ae94a00 0 0x1e0>;
- reg-names = "dsi0_phy",
- "dsi0_phy_lane",
+ reg-names = "dsi_phy",
+ "dsi_phy_lane",
"dsi_pll";

#clock-cells = <1>;

--
2.41.0


2023-06-27 17:02:38

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH 10/11] dt-bindings: usb: dwc3: Allow just 1 interrupt for MSM8996

MSM8996, similarly to SDM660 has two DWC3 controllers: one for SS and
another one for HS operation. Allow just specifying the HS interrupt
in the latter case.

Signed-off-by: Konrad Dybcio <[email protected]>
---
Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
index aca20aa8f504..beaeba47a150 100644
--- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
@@ -394,7 +394,6 @@ allOf:
contains:
enum:
- qcom,msm8953-dwc3
- - qcom,msm8996-dwc3
- qcom,msm8998-dwc3
- qcom,sm6115-dwc3
then:
@@ -411,6 +410,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,msm8996-dwc3
- qcom,sdm660-dwc3
then:
properties:

--
2.41.0


2023-06-27 17:48:24

by Bryan O'Donoghue

[permalink] [raw]
Subject: Re: [PATCH 04/11] arm64: dts: qcom: apq8039-t2: Drop inexistent property

On 27/06/2023 17:24, Konrad Dybcio wrote:
> 'pin-switch-delay-us' is not used anywhere in the mainline kernel.
> Drop it.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---

Reviewed-by: Bryan O'Donoghue <[email protected]>

2023-06-29 15:57:37

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional


On Tue, 27 Jun 2023 18:24:25 +0200, Konrad Dybcio wrote:
> The description of reg[1] says that register is optional. Adjust
> minItems to make it truly optional.
>
> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/msm/qcom,kpss-acc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>

Acked-by: Rob Herring <[email protected]>


2023-06-29 16:24:06

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 10/11] dt-bindings: usb: dwc3: Allow just 1 interrupt for MSM8996


On Tue, 27 Jun 2023 18:24:26 +0200, Konrad Dybcio wrote:
> MSM8996, similarly to SDM660 has two DWC3 controllers: one for SS and
> another one for HS operation. Allow just specifying the HS interrupt
> in the latter case.
>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>

Acked-by: Rob Herring <[email protected]>


2023-07-10 05:32:19

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 00/11] Even more msm bindings fixes


On Tue, 27 Jun 2023 18:24:16 +0200, Konrad Dybcio wrote:
> This series contains couple more random dt schema warning fixes, centered
> around linux-msm.
>
> All of the patches (except) the last two are pretty much independent.
> Patch 1 is not only a bindings fix, but also a functional one.
>
>
> [...]

Applied, thanks!

[01/11] arm64: dts: qcom: sc7180: Fix DSI0_PHY reg-names
commit: afc19e3716c3bc32c31baac54e3a9057661979ad
[02/11] arm64: dts: qcom: msm8939: Drop "qcom,idle-state-spc" compatible
commit: 982f810fc196002808b6d4230ba8f431c993d264
[03/11] arm64: dts: qcom: msm8939: Add missing 'cache-unified' to L2
commit: 68a59251f1c590ad567ff7fd799f6634fbab6e16
[04/11] arm64: dts: qcom: apq8039-t2: Drop inexistent property
commit: 9cc6dee9b3a8aea0af836d365793ffce47bc7a11
[11/11] arm64: dts: qcom: msm8996: Add missing interrupt to the USB2 controller
commit: 36541089c4733355ed844c67eebd0c3936953454

Best regards,
--
Bjorn Andersson <[email protected]>

2023-07-12 12:21:54

by Mark Brown

[permalink] [raw]
Subject: Re: (subset) [PATCH 00/11] Even more msm bindings fixes

On Tue, 27 Jun 2023 18:24:16 +0200, Konrad Dybcio wrote:
> This series contains couple more random dt schema warning fixes, centered
> around linux-msm.
>
> All of the patches (except) the last two are pretty much independent.
> Patch 1 is not only a bindings fix, but also a functional one.
>
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[05/11] dt-bindings: sound: Convert pm8916-wcd-analog-codec to YAML
commit: e125891c2ed6f6d3f59375caf04d76802c86efae

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark


2023-07-22 05:15:35

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 00/11] Even more msm bindings fixes


On Tue, 27 Jun 2023 18:24:16 +0200, Konrad Dybcio wrote:
> This series contains couple more random dt schema warning fixes, centered
> around linux-msm.
>
> All of the patches (except) the last two are pretty much independent.
> Patch 1 is not only a bindings fix, but also a functional one.
>
>
> [...]

Applied, thanks!

[09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional
commit: 981be238e1d28e156aa9da2a8722f86f02fd0453

Best regards,
--
Bjorn Andersson <[email protected]>

2023-07-24 10:22:48

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional

On 24/07/2023 11:05, Krzysztof Kozlowski wrote:
> On 27/06/2023 18:24, Konrad Dybcio wrote:
>> The description of reg[1] says that register is optional. Adjust
>> minItems to make it truly optional.
>>
>> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
>> Signed-off-by: Konrad Dybcio <[email protected]>
>> ---
>
> This patch does not make sense. It wasn't also tested. The code
> (minItems) is already there.


What's more - there is no such commit as 12f40018b6a9!

Bjorn,
You might find this useful (fake Fixes tag should be detected):
https://github.com/krzk/tools/blob/master/linux/git-hooks-post-commit

Best regards,
Krzysztof


2023-07-24 11:08:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 09/11] dt-bindings: arm: msm: kpss-acc: Make the optional reg truly optional

On 27/06/2023 18:24, Konrad Dybcio wrote:
> The description of reg[1] says that register is optional. Adjust
> minItems to make it truly optional.
>
> Fixes: 12f40018b6a9 ("dt-bindings: arm: msm: Convert kpss-acc driver Documentation to yaml")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---

This patch does not make sense. It wasn't also tested. The code
(minItems) is already there.

Best regards,
Krzysztof


2023-07-25 15:23:25

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH 01/11] arm64: dts: qcom: sc7180: Fix DSI0_PHY reg-names

Hi,

On Tue, Jun 27, 2023 at 9:24 AM Konrad Dybcio <[email protected]> wrote:
>
> Commit 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI
> nodes") broke reg-names, possibly with search-and-replace. Fix it.
>
> Fixes: 2b616f86d51b ("arm64: dts: qcom: sc7180: rename labels for DSI nodes")
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 34eff97f8630..b9640574e73b 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -3120,8 +3120,8 @@ mdss_dsi0_phy: phy@ae94400 {
> reg = <0 0x0ae94400 0 0x200>,
> <0 0x0ae94600 0 0x280>,
> <0 0x0ae94a00 0 0x1e0>;
> - reg-names = "dsi0_phy",
> - "dsi0_phy_lane",
> + reg-names = "dsi_phy",
> + "dsi_phy_lane",

I noticed that this patch got applied [1], but I think it got put into
a branch targeting 6.6 instead of 6.5. Specifically I see it in
"arm64-for-6.6" but not "arm64-fixes-for-6.5". Any chance it could be
landed in a "Fixes" tree and get sent out sooner rather than later?
v6.5 will be pretty broken without it and it would be nice to see it
in Linus's tree sooner rather than later.

[1] https://lore.kernel.org/r/[email protected]

Thanks!

-Doug