2023-05-31 02:59:50

by Bjorn Andersson

Subject: [PATCH] arm64: dts: qcom: Drop undocumented "svid" property

The Linux typec_mux implementation required that a property named "svid"
was present in the remote node of the of_graph for a match to be found.

With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
mux_fwnode_match()")', the implementation is aligned with the binding
and this property can be dropped - and the associated DeviceTree
validation warning resolved.

Signed-off-by: Bjorn Andersson <[email protected]>
---

The referred to patch is present in usb-next.

arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 2 --
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 2 --
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 1 -
arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 1 -
4 files changed, 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
index cd7e0097d8bc..4594ef4c1f38 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
@@ -229,7 +229,6 @@ usb0-sbu-mux {

mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

port {
usb0_sbu_mux: endpoint {
@@ -249,7 +248,6 @@ usb1-sbu-mux {

mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

port {
usb1_sbu_mux: endpoint {
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
index 5ae057ad6438..a93170e57229 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts
@@ -329,7 +329,6 @@ usb0-sbu-mux {

mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

port {
usb0_sbu_mux: endpoint {
@@ -349,7 +348,6 @@ usb1-sbu-mux {

mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

port {
usb1_sbu_mux: endpoint {
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index d3788bd72ac3..0c4829e876f3 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -348,7 +348,6 @@ typec-mux@42 {
vcc-supply = <&vreg_bob>;
mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

ports {
#address-cells = <1>;
diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
index d5aeb7319776..c9676e7f2c69 100644
--- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts
@@ -517,7 +517,6 @@ typec-mux@42 {
vcc-supply = <&vreg_bob>;
mode-switch;
orientation-switch;
- svid = /bits/ 16 <0xff01>;

ports {
#address-cells = <1>;
--
2.25.1

2023-05-31 09:53:04

by Neil Armstrong

Subject: Re: [PATCH] arm64: dts: qcom: Drop undocumented "svid" property

On 31/05/2023 04:49, Bjorn Andersson wrote:
> The Linux typec_mux implementation required that a property named "svid"
> was present in the remote node of the of_graph for a match to be found.
>
> With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
> mux_fwnode_match()")', the implementation is aligned with the binding
> and this property can be dropped - and the associated DeviceTree
> validation warning resolved.
>
> Signed-off-by: Bjorn Andersson <[email protected]>
> ---
>
> The referred to patch is present in usb-next.
>

Reviewed-by: Neil Armstrong <[email protected]>

2023-07-10 05:32:24

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: Drop undocumented "svid" property

On Tue, 30 May 2023 19:49:44 -0700, Bjorn Andersson wrote:
> The Linux typec_mux implementation required that a property named "svid"
> was present in the remote node of the of_graph for a match to be found.
>
> With the introduction of commit '4aebc4f89f00 ("usb: typec: mux: Clean up
> mux_fwnode_match()")', the implementation is aligned with the binding
> and this property can be dropped - and the associated DeviceTree
> validation warning resolved.
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: Drop undocumented "svid" property
commit: e0f250c8fd012b010cdae0535903402765f7ffe5

Best regards,
--
Bjorn Andersson <[email protected]>