2023-06-17 11:40:04

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 1/2] arm64: dts: qcom: apq8039-t2: remove superfluous "input-enable"

Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
output-disable, not input-enable") the property is not accepted anymore.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8039-t2.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
index 40644c242fb7..43686bbd87f4 100644
--- a/arch/arm64/boot/dts/qcom/apq8039-t2.dts
+++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
@@ -366,7 +366,6 @@ typec_irq: typec-irq-state {
function = "gpio";
pins = "gpio107";
bias-pull-up;
- input-enable;
};
};

--
2.34.1



2023-06-17 11:57:59

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH 2/2] arm64: dts: qcom: sc8180x-flex-5g: remove superfluous "input-enable"

Pin configuration property "input-enable" was used with the intention to
disable the output, but this is done by default by Linux drivers. Since
commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
output-disable, not input-enable") the property is not accepted anymore.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 3 ---
1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
index fe3b366e1435..b12e0a61b3c0 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
+++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
@@ -497,7 +497,6 @@ hall_int_active_state: hall-int-active-state {
pins = "gpio121";
function = "gpio";

- input-enable;
bias-disable;
};

@@ -513,7 +512,6 @@ i2c1_hid_active: i2c1-hid-active-state {
pins = "gpio122";
function = "gpio";

- input-enable;
bias-pull-up;
drive-strength = <2>;
};
@@ -530,7 +528,6 @@ i2c7_hid_active: i2c7-hid-active-state {
pins = "gpio37", "gpio24";
function = "gpio";

- input-enable;
bias-pull-up;
drive-strength = <2>;
};
--
2.34.1


2023-06-19 13:30:43

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 2/2] arm64: dts: qcom: sc8180x-flex-5g: remove superfluous "input-enable"

On 17.06.2023 13:21, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
> output-disable, not input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> index fe3b366e1435..b12e0a61b3c0 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8180x-lenovo-flex-5g.dts
> @@ -497,7 +497,6 @@ hall_int_active_state: hall-int-active-state {
> pins = "gpio121";
> function = "gpio";
>
> - input-enable;
> bias-disable;
> };
>
> @@ -513,7 +512,6 @@ i2c1_hid_active: i2c1-hid-active-state {
> pins = "gpio122";
> function = "gpio";
>
> - input-enable;
> bias-pull-up;
> drive-strength = <2>;
> };
> @@ -530,7 +528,6 @@ i2c7_hid_active: i2c7-hid-active-state {
> pins = "gpio37", "gpio24";
> function = "gpio";
>
> - input-enable;
> bias-pull-up;
> drive-strength = <2>;
> };

2023-06-19 13:31:42

by Konrad Dybcio

[permalink] [raw]
Subject: Re: [PATCH 1/2] arm64: dts: qcom: apq8039-t2: remove superfluous "input-enable"

On 17.06.2023 13:21, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
> output-disable, not input-enable") the property is not accepted anymore.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> arch/arm64/boot/dts/qcom/apq8039-t2.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8039-t2.dts b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> index 40644c242fb7..43686bbd87f4 100644
> --- a/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8039-t2.dts
> @@ -366,7 +366,6 @@ typec_irq: typec-irq-state {
> function = "gpio";
> pins = "gpio107";
> bias-pull-up;
> - input-enable;
> };
> };
>

2023-07-10 05:28:08

by Bjorn Andersson

[permalink] [raw]
Subject: Re: (subset) [PATCH 1/2] arm64: dts: qcom: apq8039-t2: remove superfluous "input-enable"


On Sat, 17 Jun 2023 13:21:14 +0200, Krzysztof Kozlowski wrote:
> Pin configuration property "input-enable" was used with the intention to
> disable the output, but this is done by default by Linux drivers. Since
> commit c4a48b0df8bf ("dt-bindings: pinctrl: qcom: tlmm should use
> output-disable, not input-enable") the property is not accepted anymore.
>
>

Applied, thanks!

[1/2] arm64: dts: qcom: apq8039-t2: remove superfluous "input-enable"
commit: 9e3a0c7acba5e1ec7b0730bac904ba820b70b5cf
[2/2] arm64: dts: qcom: sc8180x-flex-5g: remove superfluous "input-enable"
commit: ba492bea16e2c036ef5725f166f1d20835b6e114

Best regards,
--
Bjorn Andersson <[email protected]>