2023-07-05 15:12:29

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: sc8180x: Fix cluster PSCI suspend param

The value was copypasted from 8150, but 8180 expects a different one.
Confirmed with both downstream device tree and Windows DSDT, not tested
on hardware (sorry, I don't have any).

Fix it.

Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
Signed-off-by: Konrad Dybcio <[email protected]>
---
arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index be78a933d8eb..e58f931c2e45 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -298,7 +298,7 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
domain-idle-states {
CLUSTER_SLEEP_0: cluster-sleep-0 {
compatible = "domain-idle-state";
- arm,psci-suspend-param = <0x4100c244>;
+ arm,psci-suspend-param = <0x4100a344>;
entry-latency-us = <3263>;
exit-latency-us = <6562>;
min-residency-us = <9987>;

---
base-commit: e1f6a8eaf1c271a0158114a03e3605f4fba059ad
change-id: 20230705-topic-8180_sleep-e40beb42250a

Best regards,
--
Konrad Dybcio <[email protected]>



2023-07-05 17:54:45

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Fix cluster PSCI suspend param

On Wed, Jul 05, 2023 at 05:00:05PM +0200, Konrad Dybcio wrote:
> The value was copypasted from 8150, but 8180 expects a different one.
> Confirmed with both downstream device tree and Windows DSDT, not tested
> on hardware (sorry, I don't have any).
>
> Fix it.
>
> Fixes: 8575f197b077 ("arm64: dts: qcom: Introduce the SC8180x platform")
> Signed-off-by: Konrad Dybcio <[email protected]>

Reviewed-by: Bjorn Andersson <[email protected]>

Regards,
Bjorn


> ---
> arch/arm64/boot/dts/qcom/sc8180x.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> index be78a933d8eb..e58f931c2e45 100644
> --- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
> @@ -298,7 +298,7 @@ BIG_CPU_SLEEP_0: cpu-sleep-1-0 {
> domain-idle-states {
> CLUSTER_SLEEP_0: cluster-sleep-0 {
> compatible = "domain-idle-state";
> - arm,psci-suspend-param = <0x4100c244>;
> + arm,psci-suspend-param = <0x4100a344>;
> entry-latency-us = <3263>;
> exit-latency-us = <6562>;
> min-residency-us = <9987>;
>
> ---
> base-commit: e1f6a8eaf1c271a0158114a03e3605f4fba059ad
> change-id: 20230705-topic-8180_sleep-e40beb42250a
>
> Best regards,
> --
> Konrad Dybcio <[email protected]>
>

2023-07-10 05:24:10

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: sc8180x: Fix cluster PSCI suspend param


On Wed, 05 Jul 2023 17:00:05 +0200, Konrad Dybcio wrote:
> The value was copypasted from 8150, but 8180 expects a different one.
> Confirmed with both downstream device tree and Windows DSDT, not tested
> on hardware (sorry, I don't have any).
>
> Fix it.
>
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: sc8180x: Fix cluster PSCI suspend param
commit: 9c31a3f5abc9eeb6509d06041b1e5f12deb39c4d

Best regards,
--
Bjorn Andersson <[email protected]>