2023-07-01 05:58:41

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH RESEND] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER

When RESET_CONTROLLER is not set, kconfig complains about missing
dependencies for RESET_TI_SYSCON, so add the missing dependency
just as is done above for SCSI_UFS_QCOM.

Silences this kconfig warning:

WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
Selected by [m]:
- SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]

Fixes: de48898d0cb6 ("scsi: ufs-mediatek: Create reset control device_link")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Link: lore.kernel.org/r/[email protected]
Cc: Stanley Chu <[email protected]>
Cc: Peter Wang <[email protected]>
Cc: Paul Gazzillo <[email protected]>
Cc: Necip Fazil Yildiran <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: "James E.J. Bottomley" <[email protected]>
Cc: "Martin K. Petersen" <[email protected]>
---
drivers/ufs/host/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff -- a/drivers/ufs/host/Kconfig b/drivers/ufs/host/Kconfig
--- a/drivers/ufs/host/Kconfig
+++ b/drivers/ufs/host/Kconfig
@@ -72,6 +72,7 @@ config SCSI_UFS_QCOM
config SCSI_UFS_MEDIATEK
tristate "Mediatek specific hooks to UFS controller platform driver"
depends on SCSI_UFSHCD_PLATFORM && ARCH_MEDIATEK
+ depends on RESET_CONTROLLER
select PHY_MTK_UFS
select RESET_TI_SYSCON
help


2023-07-06 02:05:33

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH RESEND] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER


Randy,

> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency just
> as is done above for SCSI_UFS_QCOM.

Applied to 6.5/scsi-staging, thanks!

--
Martin K. Petersen Oracle Linux Engineering

2023-07-11 16:42:41

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH RESEND] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER

On Fri, 30 Jun 2023 22:23:48 -0700, Randy Dunlap wrote:

> When RESET_CONTROLLER is not set, kconfig complains about missing
> dependencies for RESET_TI_SYSCON, so add the missing dependency
> just as is done above for SCSI_UFS_QCOM.
>
> Silences this kconfig warning:
>
> WARNING: unmet direct dependencies detected for RESET_TI_SYSCON
> Depends on [n]: RESET_CONTROLLER [=n] && HAS_IOMEM [=y]
> Selected by [m]:
> - SCSI_UFS_MEDIATEK [=m] && SCSI_UFSHCD [=y] && SCSI_UFSHCD_PLATFORM [=y] && ARCH_MEDIATEK [=y]
>
> [...]

Applied to 6.5/scsi-fixes, thanks!

[1/1] scsi: ufs-mediatek: add dependency for RESET_CONTROLLER
https://git.kernel.org/mkp/scsi/c/89f7ef7f2b23

--
Martin K. Petersen Oracle Linux Engineering