2023-07-21 17:44:01

by Mrinmay Sarkar

Subject: [PATCH v3 1/4] dt-bindings: PCI: qcom: Add sa8775p compatible

Add sa8775p platform to the binding.

Signed-off-by: Mrinmay Sarkar <[email protected]>
Reviewed-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/pci/qcom,pcie.yaml | 28 ++++++++++++++++++++++
1 file changed, 28 insertions(+)

diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
index 81971be4..eadba38 100644
--- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
+++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
@@ -29,6 +29,7 @@ properties:
- qcom,pcie-msm8996
- qcom,pcie-qcs404
- qcom,pcie-sa8540p
+ - qcom,pcie-sa8775p
- qcom,pcie-sc7280
- qcom,pcie-sc8180x
- qcom,pcie-sc8280xp
@@ -211,6 +212,7 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pcie-sa8775p
- qcom,pcie-sc7280
- qcom,pcie-sc8180x
- qcom,pcie-sc8280xp
@@ -748,7 +750,32 @@ allOf:
compatible:
contains:
enum:
+ - qcom,pcie-sa8775p
+ then:
+ properties:
+ clocks:
+ minItems: 5
+ maxItems: 5
+ clock-names:
+ items:
+ - const: aux # Auxiliary clock
+ - const: cfg # Configuration clock
+ - const: bus_master # Master AXI clock
+ - const: bus_slave # Slave AXI clock
+ - const: slave_q2a # Slave Q2A clock
+ resets:
+ maxItems: 1
+ reset-names:
+ items:
+ - const: pci # PCIe core reset
+
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
- qcom,pcie-sa8540p
+ - qcom,pcie-sa8775p
- qcom,pcie-sc8280xp
then:
required:
@@ -790,6 +817,7 @@ allOf:
contains:
enum:
- qcom,pcie-msm8996
+ - qcom,pcie-sa8775p
- qcom,pcie-sc7280
- qcom,pcie-sc8180x
- qcom,pcie-sdm845
--
2.7.4

2023-07-24 06:34:13

by Manivannan Sadhasivam

Subject: Re: [PATCH v3 1/4] dt-bindings: PCI: qcom: Add sa8775p compatible

On Fri, Jul 21, 2023 at 10:54:32PM +0530, Mrinmay Sarkar wrote:
> Add sa8775p platform to the binding.
>
> Signed-off-by: Mrinmay Sarkar <[email protected]>

Acked-by: Manivannan Sadhasivam <[email protected]>

- Mani

> Reviewed-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/pci/qcom,pcie.yaml | 28 ++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> index 81971be4..eadba38 100644
> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
> @@ -29,6 +29,7 @@ properties:
> - qcom,pcie-msm8996
> - qcom,pcie-qcs404
> - qcom,pcie-sa8540p
> + - qcom,pcie-sa8775p
> - qcom,pcie-sc7280
> - qcom,pcie-sc8180x
> - qcom,pcie-sc8280xp
> @@ -211,6 +212,7 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,pcie-sa8775p
> - qcom,pcie-sc7280
> - qcom,pcie-sc8180x
> - qcom,pcie-sc8280xp
> @@ -748,7 +750,32 @@ allOf:
> compatible:
> contains:
> enum:
> + - qcom,pcie-sa8775p
> + then:
> + properties:
> + clocks:
> + minItems: 5
> + maxItems: 5
> + clock-names:
> + items:
> + - const: aux # Auxiliary clock
> + - const: cfg # Configuration clock
> + - const: bus_master # Master AXI clock
> + - const: bus_slave # Slave AXI clock
> + - const: slave_q2a # Slave Q2A clock
> + resets:
> + maxItems: 1
> + reset-names:
> + items:
> + - const: pci # PCIe core reset
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + enum:
> - qcom,pcie-sa8540p
> + - qcom,pcie-sa8775p
> - qcom,pcie-sc8280xp
> then:
> required:
> @@ -790,6 +817,7 @@ allOf:
> contains:
> enum:
> - qcom,pcie-msm8996
> + - qcom,pcie-sa8775p
> - qcom,pcie-sc7280
> - qcom,pcie-sc8180x
> - qcom,pcie-sdm845
> --
> 2.7.4
>

--
மணிவண்ணன் சதாசிவம்