LinuxLists.cc - [PATCH v3 0/3] Add regulators support for PMX75

2023-07-11 08:04:57

Subject: [PATCH v3 0/3] Add regulators support for PMX75

Hi,

Changes in v3:
- Created a separate patch for updating the entry in pmx65 bindings.
- Changed the subject of patches [1/3] and [2/3] according to the convention.

Changes in v2:
- Addressed Krzysztof to update the if:then: in bindings patch.
- Breaking the original series [1] into smaller series.

This series adds regulators supports in PMX75 found on
SDX75 platform.

[1] https://lore.kernel.org/all/[email protected]/

Thanks,
Rohit.

Rohit Agarwal (3):
regulator: dt-bindings: qcom,rpmh: Update PMX65 entry
regulator: dt-bindings: qcom,rpmh: Add PMX75 compatible
regulator: qcom-rpmh: Add regulators support for PMX75

.../bindings/regulator/qcom,rpmh-regulator.yaml | 22 ++++++++++++-
drivers/regulator/qcom-rpmh-regulator.c | 38 ++++++++++++++++++++++
2 files changed, 59 insertions(+), 1 deletion(-)

--
2.7.4

2023-07-11 08:05:40

by Rohit Agarwal

[permalink] [raw]

Subject: [PATCH v3 1/3] regulator: dt-bindings: qcom,rpmh: Update PMX65 entry

PMX65 does not have vdd-l18-supply separately and its
already part of vdd-l2-l18-supply property specified.
Updating this PMX65 dt-bindings entry accordingly.

Signed-off-by: Rohit Agarwal <[email protected]>
---
Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index b949850..12a1e0c 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -424,7 +424,7 @@ allOf:
vdd-l11-l13-supply: true
patternProperties:
"^vdd-l[1347]-supply$": true
- "^vdd-l1[0245789]-supply$": true
+ "^vdd-l1[024579]-supply$": true
"^vdd-l2[01]-supply$": true
"^vdd-s[1-8]-supply$": true

--
2.7.4

2023-07-11 08:06:56

by Rohit Agarwal

[permalink] [raw]

Subject: [PATCH v3 2/3] regulator: dt-bindings: qcom,rpmh: Add PMX75 compatible

Add PMX75 compatibles for PMIC found in SDX75 platform.

Signed-off-by: Rohit Agarwal <[email protected]>
---
.../bindings/regulator/qcom,rpmh-regulator.yaml | 20 ++++++++++++++++++++
1 file changed, 20 insertions(+)

diff --git a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
index 12a1e0c..72b533c 100644
--- a/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
+++ b/Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.yaml
@@ -53,6 +53,7 @@ description: |
For PMR735A, smps1 - smps3, ldo1 - ldo7
For PMX55, smps1 - smps7, ldo1 - ldo16
For PMX65, smps1 - smps8, ldo1 - ldo21
+ For PMX75, smps1 - smps10, ldo1 - ldo21

properties:
compatible:
@@ -84,6 +85,7 @@ properties:
- qcom,pmr735a-rpmh-regulators
- qcom,pmx55-rpmh-regulators
- qcom,pmx65-rpmh-regulators
+ - qcom,pmx75-rpmh-regulators

qcom,pmic-id:
description: |
@@ -428,6 +430,24 @@ allOf:
"^vdd-l2[01]-supply$": true
"^vdd-s[1-8]-supply$": true

+ - if:
+ properties:
+ compatible:
+ enum:
+ - qcom,pmx75-rpmh-regulators
+ then:
+ properties:
+ vdd-l2-l18-supply: true
+ vdd-l4-l16-supply: true
+ vdd-l5-l6-supply: true
+ vdd-l8-l9-supply: true
+ vdd-l11-l13-supply: true
+ vdd-l20-l21-supply: true
+ patternProperties:
+ "^vdd-l[137]-supply$": true
+ "^vdd-l1[024579]-supply$": true
+ "^vdd-s([1-9]|10)-supply$": true
+
unevaluatedProperties: false

examples:
--
2.7.4

2023-07-11 08:14:48

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH v3 2/3] regulator: dt-bindings: qcom,rpmh: Add PMX75 compatible

On 11/07/2023 10:00, Rohit Agarwal wrote:
> Add PMX75 compatibles for PMIC found in SDX75 platform.
>
> Signed-off-by: Rohit Agarwal <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-07-11 08:16:32

by Krzysztof Kozlowski

[permalink] [raw]

Subject: Re: [PATCH v3 1/3] regulator: dt-bindings: qcom,rpmh: Update PMX65 entry

On 11/07/2023 10:00, Rohit Agarwal wrote:
> PMX65 does not have vdd-l18-supply separately and its
> already part of vdd-l2-l18-supply property specified.
> Updating this PMX65 dt-bindings entry accordingly.
>
> Signed-off-by: Rohit Agarwal <[email protected]>
> ---

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-07-11 08:16:38

by Rohit Agarwal

[permalink] [raw]

Subject: [PATCH v3 3/3] regulator: qcom-rpmh: Add regulators support for PMX75

Add support from RPMH regulators found in PMX75 for SDX75 platform.

Signed-off-by: Rohit Agarwal <[email protected]>
---
drivers/regulator/qcom-rpmh-regulator.c | 38 +++++++++++++++++++++++++++++++++
1 file changed, 38 insertions(+)

diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index f3b280a..0881e91 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -1273,6 +1273,40 @@ static const struct rpmh_vreg_init_data pmx65_vreg_data[] = {
{}
};

+static const struct rpmh_vreg_init_data pmx75_vreg_data[] = {
+ RPMH_VREG("smps1", "smp%s1", &pmic5_ftsmps525_lv, "vdd-s1"),
+ RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps525_lv, "vdd-s2"),
+ RPMH_VREG("smps3", "smp%s3", &pmic5_ftsmps525_lv, "vdd-s3"),
+ RPMH_VREG("smps4", "smp%s4", &pmic5_ftsmps525_mv, "vdd-s4"),
+ RPMH_VREG("smps5", "smp%s5", &pmic5_ftsmps525_lv, "vdd-s5"),
+ RPMH_VREG("smps6", "smp%s6", &pmic5_ftsmps525_lv, "vdd-s6"),
+ RPMH_VREG("smps7", "smp%s7", &pmic5_ftsmps525_lv, "vdd-s7"),
+ RPMH_VREG("smps8", "smp%s8", &pmic5_ftsmps525_lv, "vdd-s8"),
+ RPMH_VREG("smps9", "smp%s9", &pmic5_ftsmps525_lv, "vdd-s9"),
+ RPMH_VREG("smps10", "smp%s10", &pmic5_ftsmps525_lv, "vdd-s10"),
+ RPMH_VREG("ldo1", "ldo%s1", &pmic5_nldo515, "vdd-l1"),
+ RPMH_VREG("ldo2", "ldo%s2", &pmic5_nldo515, "vdd-l2-18"),
+ RPMH_VREG("ldo3", "ldo%s3", &pmic5_nldo515, "vdd-l3"),
+ RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo515, "vdd-l4-l16"),
+ RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo_lv, "vdd-l5-l6"),
+ RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo_lv, "vdd-l5-l6"),
+ RPMH_VREG("ldo7", "ldo%s7", &pmic5_nldo515, "vdd-l7"),
+ RPMH_VREG("ldo8", "ldo%s8", &pmic5_nldo515, "vdd-l8-l9"),
+ RPMH_VREG("ldo9", "ldo%s9", &pmic5_nldo515, "vdd-l8-l9"),
+ RPMH_VREG("ldo10", "ldo%s10", &pmic5_pldo, "vdd-l10"),
+ RPMH_VREG("ldo11", "ldo%s11", &pmic5_pldo, "vdd-l11-l13"),
+ RPMH_VREG("ldo12", "ldo%s12", &pmic5_nldo515, "vdd-l12"),
+ RPMH_VREG("ldo13", "ldo%s13", &pmic5_pldo, "vdd-l11-l13"),
+ RPMH_VREG("ldo14", "ldo%s14", &pmic5_nldo515, "vdd-l14"),
+ RPMH_VREG("ldo15", "ldo%s15", &pmic5_nldo515, "vdd-l15"),
+ RPMH_VREG("ldo16", "ldo%s16", &pmic5_nldo515, "vdd-l4-l16"),
+ RPMH_VREG("ldo17", "ldo%s17", &pmic5_nldo515, "vdd-l17"),
+ /* ldo18 not configured */
+ RPMH_VREG("ldo19", "ldo%s19", &pmic5_nldo515, "vdd-l19"),
+ RPMH_VREG("ldo20", "ldo%s20", &pmic5_nldo515, "vdd-l20-l21"),
+ RPMH_VREG("ldo21", "ldo%s21", &pmic5_nldo515, "vdd-l20-l21"),
+};
+
static const struct rpmh_vreg_init_data pm7325_vreg_data[] = {
RPMH_VREG("smps1", "smp%s1", &pmic5_hfsmps510, "vdd-s1"),
RPMH_VREG("smps2", "smp%s2", &pmic5_ftsmps520, "vdd-s2"),
@@ -1495,6 +1529,10 @@ static const struct of_device_id __maybe_unused rpmh_regulator_match_table[] = {
.data = pmx65_vreg_data,
},
{
+ .compatible = "qcom,pmx75-rpmh-regulators",
+ .data = pmx75_vreg_data,
+ },
+ {
.compatible = "qcom,pm7325-rpmh-regulators",
.data = pm7325_vreg_data,
},
--
2.7.4

2023-07-21 14:58:15

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH v3 0/3] Add regulators support for PMX75

On Tue, 11 Jul 2023 13:30:11 +0530, Rohit Agarwal wrote:
> Changes in v3:
> - Created a separate patch for updating the entry in pmx65 bindings.
> - Changed the subject of patches [1/3] and [2/3] according to the convention.
>
> Changes in v2:
> - Addressed Krzysztof to update the if:then: in bindings patch.
> - Breaking the original series [1] into smaller series.
>
> [...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/3] regulator: dt-bindings: qcom,rpmh: Update PMX65 entry
commit: 4fdef8553df58953f572f1cb46d357c735c683a9
[2/3] regulator: dt-bindings: qcom,rpmh: Add PMX75 compatible
commit: 0ef3d931632e3fce51ed5510935238937d644c97
[3/3] regulator: qcom-rpmh: Add regulators support for PMX75
commit: 0b294ed669ead34a348d17d06b6d4d58712b14e2

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

2023-07-25 17:16:29

by Mark Brown

[permalink] [raw]