From: Arnd Bergmann <[email protected]>
The added HAS_IOPORT dependency might not actually be necessary as Geert
points out, but the driver is also only used on one architecture. Sparc
is also a special case here since it converts port numbers into virtual
addresses rather than having them mapped into a particular part of the
__iomem address space, so the difference is actually not important here.
Add a dependency on sparc, but allow compile-testing otherwise, to
make this clearer without anyone having to spend much time modernizing
the driver beyond that.
Reported-by: Geert Uytterhoeven <[email protected]>
Cc: David S. Miller <[email protected]>
Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/
Signed-off-by: Arnd Bergmann <[email protected]>
---
v2: split dependency into two lines, as suggested by Geert
---
drivers/rtc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig
index 05f4b2d66290d..19c3eac474f7c 100644
--- a/drivers/rtc/Kconfig
+++ b/drivers/rtc/Kconfig
@@ -1196,6 +1196,7 @@ config RTC_DRV_MSM6242
config RTC_DRV_BQ4802
tristate "TI BQ4802"
depends on HAS_IOMEM && HAS_IOPORT
+ depends on SPARC || COMPILE_TEST
help
If you say Y here you will get support for the TI
BQ4802 RTC chip.
--
2.39.2
On Wed, Jul 19, 2023 at 9:28 PM Arnd Bergmann <[email protected]> wrote:
> From: Arnd Bergmann <[email protected]>
>
> The added HAS_IOPORT dependency might not actually be necessary as Geert
> points out, but the driver is also only used on one architecture. Sparc
> is also a special case here since it converts port numbers into virtual
> addresses rather than having them mapped into a particular part of the
> __iomem address space, so the difference is actually not important here.
>
> Add a dependency on sparc, but allow compile-testing otherwise, to
> make this clearer without anyone having to spend much time modernizing
> the driver beyond that.
>
> Reported-by: Geert Uytterhoeven <[email protected]>
> Cc: David S. Miller <[email protected]>
> Link: https://lore.kernel.org/all/CAMuHMdWEx0F=fNei4Bz_JPkuvoaN-+zk08h0i8KnSi_VjO615g@mail.gmail.com/
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
> v2: split dependency into two lines, as suggested by Geert
Reviewed-by: Geert Uytterhoeven <[email protected]>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Wed, 19 Jul 2023 21:28:18 +0200, Arnd Bergmann wrote:
> The added HAS_IOPORT dependency might not actually be necessary as Geert
> points out, but the driver is also only used on one architecture. Sparc
> is also a special case here since it converts port numbers into virtual
> addresses rather than having them mapped into a particular part of the
> __iomem address space, so the difference is actually not important here.
>
> Add a dependency on sparc, but allow compile-testing otherwise, to
> make this clearer without anyone having to spend much time modernizing
> the driver beyond that.
>
> [...]
Applied, thanks!
[1/1] rtc: bq4802: add sparc dependency
commit: 766c3f8a092b4d42abd68ee0338349838430a5ee
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com