2023-07-26 07:28:14

by Eugen Hristev

Subject: [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema

The range and the defaults are specified in the description instead of
being specified in the schema.
Fix it by adding the default value in the `default` field and specifying
the range as `minimum` and `maximum`.

Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
Signed-off-by: Eugen Hristev <[email protected]>
---
changes in v2:
- also move the range as minimum/maximum in the schema

.../devicetree/bindings/net/rockchip-dwmac.yaml | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
index bb943c96c196..70bbc4220e2a 100644
--- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
@@ -92,12 +92,18 @@ properties:
$ref: /schemas/types.yaml#/definitions/phandle

tx_delay:
- description: Delay value for TXD timing. Range value is 0~0x7F, 0x30 as default.
+ description: Delay value for TXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x30

rx_delay:
- description: Delay value for RXD timing. Range value is 0~0x7F, 0x10 as default.
+ description: Delay value for RXD timing.
$ref: /schemas/types.yaml#/definitions/uint32
+ minimum: 0
+ maximum: 0x7F
+ default: 0x10

phy-supply:
description: PHY regulator
--
2.34.1

2023-07-28 10:23:09

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <[email protected]>:

On Wed, 26 Jul 2023 10:06:15 +0300 you wrote:
> The range and the defaults are specified in the description instead of
> being specified in the schema.
> Fix it by adding the default value in the `default` field and specifying
> the range as `minimum` and `maximum`.
>
> Fixes: b331b8ef86f0 ("dt-bindings: net: convert rockchip-dwmac to json-schema")
> Signed-off-by: Eugen Hristev <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] dt-bindings: net: rockchip-dwmac: fix {tx|rx}-delay defaults/range in schema
https://git.kernel.org/netdev/net/c/5416d7925e6e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html