2023-07-27 03:25:38

by ZeYan Li

[permalink] [raw]
Subject: [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

I2C6 and I2C7 use the same interrupts, which is incorrect.
In the downstream kernel, I2C7 has interrupts of 608 instead of 607.

Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
Signed-off-by: Zeyan Li <[email protected]>
---
[v3] Change to use my real name
[v2] Fixed issue of not using full name

arch/arm64/boot/dts/qcom/sm8150.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi
index 18c822abdb88..214f6e028f3c 100644
--- a/arch/arm64/boot/dts/qcom/sm8150.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi
@@ -1231,7 +1231,7 @@ i2c7: i2c@89c000 {
dma-names = "tx", "rx";
pinctrl-names = "default";
pinctrl-0 = <&qup_i2c7_default>;
- interrupts = <GIC_SPI 607 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 608 IRQ_TYPE_LEVEL_HIGH>;
#address-cells = <1>;
#size-cells = <0>;
status = "disabled";
--
2.34.1



2023-07-27 07:05:10

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt

On 27/07/2023 04:53, Zeyan Li wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>
> Fixes: 81bee6953b58 ("arm64: dts: qcom: sm8150: add i2c nodes")
> Signed-off-by: Zeyan Li <[email protected]>
> ---
> [v3] Change to use my real name
> [v2] Fixed issue of not using full name

Reviewed-by: Krzysztof Kozlowski <[email protected]>


---

This is an automated instruction, just in case, because many review tags
are being ignored. If you know the process, you can skip it (please do
not feel offended by me posting it here - no bad intentions intended).
If you do not know the process, here is a short explanation:

Please add Acked-by/Reviewed-by/Tested-by tags when posting new
versions, under or above your Signed-off-by tag. Tag is "received", when
provided in a message replied to you on the mailing list. Tools like b4
can help here. However, there's no need to repost patches *only* to add
the tags. The upstream maintainer will do that for tags received on the
version they apply.

https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577

Best regards,
Krzysztof


2023-08-01 00:20:57

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH V3] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt


On Thu, 27 Jul 2023 10:53:21 +0800, Zeyan Li wrote:
> I2C6 and I2C7 use the same interrupts, which is incorrect.
> In the downstream kernel, I2C7 has interrupts of 608 instead of 607.
>
>

Applied, thanks!

[1/1] arm64: dts: qcom: sm8150: Fix the I2C7 interrupt
commit: f9568d22ce06192a7e14bda3a29dc216659554ff

Best regards,
--
Bjorn Andersson <[email protected]>