2023-07-28 06:34:59

by Jayesh Choudhary

[permalink] [raw]
Subject: [PATCH v3] soc: ti: k3-ringacc: remove non-fatal probe deferral log

Drop the non-fatal probe deferral log for getting MSI domain.
This makes the kernel log clean and we do not get recurring logs
stating: "Failed to get MSI domain".

Signed-off-by: Jayesh Choudhary <[email protected]>
---

v2 patch: <https://lore.kernel.org/all/[email protected]/>

Changelog v2->v3:
- Remove unnecessary braces for the if condition

Changelog v1->v2:
- Removed the print instead of dropping the loglevel according to the comment
on similar patch for udma:
<https://lore.kernel.org/all/Y6wiXlZh1MUL2WrF@matsya/>

drivers/soc/ti/k3-ringacc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/soc/ti/k3-ringacc.c b/drivers/soc/ti/k3-ringacc.c
index c6fdf0ad3d33..4c1353616b72 100644
--- a/drivers/soc/ti/k3-ringacc.c
+++ b/drivers/soc/ti/k3-ringacc.c
@@ -1373,10 +1373,8 @@ static int k3_ringacc_init(struct platform_device *pdev,

dev->msi.domain = of_msi_get_domain(dev, dev->of_node,
DOMAIN_BUS_TI_SCI_INTA_MSI);
- if (!dev->msi.domain) {
- dev_err(dev, "Failed to get MSI domain\n");
+ if (!dev->msi.domain)
return -EPROBE_DEFER;
- }

ret = k3_ringacc_probe_dt(ringacc);
if (ret)
--
2.25.1



2023-08-02 07:22:54

by Nishanth Menon

[permalink] [raw]
Subject: Re: [PATCH v3] soc: ti: k3-ringacc: remove non-fatal probe deferral log

Hi Jayesh Choudhary,

On Fri, 28 Jul 2023 11:03:56 +0530, Jayesh Choudhary wrote:
> Drop the non-fatal probe deferral log for getting MSI domain.
> This makes the kernel log clean and we do not get recurring logs
> stating: "Failed to get MSI domain".
>
>

I have applied the following to branch ti-drivers-soc-next on [1].
Thank you!

[1/1] soc: ti: k3-ringacc: remove non-fatal probe deferral log
commit: e50a76355c1d8581673bda987688d59e7da33928

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D