2023-08-11 13:17:02

by Andy Shevchenko

Subject: [PATCH v1 1/1] platform/x86/amd/pmf: Use str_on_off() helper

We have a common helper to represent a boolean value as "on"/"off"
string. Use it for the sake of the unified style.

Signed-off-by: Andy Shevchenko <[email protected]>
---
drivers/platform/x86/amd/pmf/cnqf.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c
index 539b186e9027..bc8899e15c91 100644
--- a/drivers/platform/x86/amd/pmf/cnqf.c
+++ b/drivers/platform/x86/amd/pmf/cnqf.c
@@ -8,6 +8,7 @@
* Author: Shyam Sundar S K <[email protected]>
*/

+#include <linux/string_choices.h>
#include <linux/workqueue.h>
#include "pmf.h"

@@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev,
amd_pmf_set_sps_power_limits(pdev);
}

- dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off");
+ dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input));
return count;
}

@@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev,
{
struct amd_pmf_dev *pdev = dev_get_drvdata(dev);

- return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off");
+ return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled));
}

static DEVICE_ATTR_RW(cnqf_enable);
--
2.40.0.1.gaa8946217a0b

2023-08-11 13:57:33

by Ilpo Järvinen

Subject: Re: [PATCH v1 1/1] platform/x86/amd/pmf: Use str_on_off() helper

On Fri, 11 Aug 2023, Andy Shevchenko wrote:

> We have a common helper to represent a boolean value as "on"/"off"
> string. Use it for the sake of the unified style.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
> ---
> drivers/platform/x86/amd/pmf/cnqf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c
> index 539b186e9027..bc8899e15c91 100644
> --- a/drivers/platform/x86/amd/pmf/cnqf.c
> +++ b/drivers/platform/x86/amd/pmf/cnqf.c
> @@ -8,6 +8,7 @@
> * Author: Shyam Sundar S K <[email protected]>
> */
>
> +#include <linux/string_choices.h>
> #include <linux/workqueue.h>
> #include "pmf.h"
>
> @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev,
> amd_pmf_set_sps_power_limits(pdev);
> }
>
> - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off");
> + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input));
> return count;
> }
>
> @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev,
> {
> struct amd_pmf_dev *pdev = dev_get_drvdata(dev);
>
> - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off");
> + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled));
> }
>
> static DEVICE_ATTR_RW(cnqf_enable);
>

Reviewed-by: Ilpo J?rvinen <[email protected]>


--
i.

2023-08-11 14:05:43

by Muhammad Usama Anjum

Subject: Re: [PATCH v1 1/1] platform/x86/amd/pmf: Use str_on_off() helper

On 8/11/23 6:13 PM, Andy Shevchenko wrote:
> We have a common helper to represent a boolean value as "on"/"off"
> string. Use it for the sake of the unified style.
>
> Signed-off-by: Andy Shevchenko <[email protected]>
Reviewed-by: Muhammad Usama Anjum <[email protected]>

> ---
> drivers/platform/x86/amd/pmf/cnqf.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/amd/pmf/cnqf.c b/drivers/platform/x86/amd/pmf/cnqf.c
> index 539b186e9027..bc8899e15c91 100644
> --- a/drivers/platform/x86/amd/pmf/cnqf.c
> +++ b/drivers/platform/x86/amd/pmf/cnqf.c
> @@ -8,6 +8,7 @@
> * Author: Shyam Sundar S K <[email protected]>
> */
>
> +#include <linux/string_choices.h>
> #include <linux/workqueue.h>
> #include "pmf.h"
>
> @@ -399,7 +400,7 @@ static ssize_t cnqf_enable_store(struct device *dev,
> amd_pmf_set_sps_power_limits(pdev);
> }
>
> - dev_dbg(pdev->dev, "Received CnQF %s\n", input ? "on" : "off");
> + dev_dbg(pdev->dev, "Received CnQF %s\n", str_on_off(input));
> return count;
> }
>
> @@ -409,7 +410,7 @@ static ssize_t cnqf_enable_show(struct device *dev,
> {
> struct amd_pmf_dev *pdev = dev_get_drvdata(dev);
>
> - return sysfs_emit(buf, "%s\n", pdev->cnqf_enabled ? "on" : "off");
> + return sysfs_emit(buf, "%s\n", str_on_off(pdev->cnqf_enabled));
> }
>
> static DEVICE_ATTR_RW(cnqf_enable);

--
BR,
Muhammad Usama Anjum