The comments in armv8pmu_[enable|disable]_event() are blindingly obvious,
and does not contribute in making things any better. Let's drop them off.
Functional change is not intended.
Cc: Will Deacon <[email protected]>
Cc: Mark Rutland <[email protected]>
Cc: [email protected]
Cc: [email protected]
Suggested-by: Mark Rutland <[email protected]>
Signed-off-by: Anshuman Khandual <[email protected]>
---
This change is taken from BRBE V13 series [PATCH 05/10] just to keep the
remaining change set in context. Mark Rutland had suggested this earlier.
https://lore.kernel.org/all/Y8AZXQJUO6h5mlgq@FVFF77S0Q05N/
drivers/perf/arm_pmuv3.c | 23 -----------------------
1 file changed, 23 deletions(-)
diff --git a/drivers/perf/arm_pmuv3.c b/drivers/perf/arm_pmuv3.c
index 08b3a1bf0ef6..b46ff9f73f42 100644
--- a/drivers/perf/arm_pmuv3.c
+++ b/drivers/perf/arm_pmuv3.c
@@ -721,38 +721,15 @@ static void armv8pmu_enable_event(struct perf_event *event)
* Enable counter and interrupt, and set the counter to count
* the event that we're interested in.
*/
-
- /*
- * Disable counter
- */
armv8pmu_disable_event_counter(event);
-
- /*
- * Set event.
- */
armv8pmu_write_event_type(event);
-
- /*
- * Enable interrupt for this counter
- */
armv8pmu_enable_event_irq(event);
-
- /*
- * Enable counter
- */
armv8pmu_enable_event_counter(event);
}
static void armv8pmu_disable_event(struct perf_event *event)
{
- /*
- * Disable counter
- */
armv8pmu_disable_event_counter(event);
-
- /*
- * Disable interrupt for this counter
- */
armv8pmu_disable_event_irq(event);
}
--
2.25.1
On Wed, 2 Aug 2023 14:38:53 +0530, Anshuman Khandual wrote:
> The comments in armv8pmu_[enable|disable]_event() are blindingly obvious,
> and does not contribute in making things any better. Let's drop them off.
> Functional change is not intended.
>
>
Applied to will (for-next/perf), thanks!
[1/1] perf: pmuv3: Remove comments from armv8pmu_[enable|disable]_event()
https://git.kernel.org/will/c/90d68677226a
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev