2022-11-27 15:55:31

by Christophe JAILLET

Subject: [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory

The 9p net files don't use IDR or IDA functionalities. So there is no point
in including <linux/idr.h>.
Remove it.

Signed-off-by: Christophe JAILLET <[email protected]>
---
net/9p/trans_fd.c | 1 -
net/9p/trans_rdma.c | 1 -
net/9p/trans_virtio.c | 1 -
3 files changed, 3 deletions(-)

diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index eeea0a6a75b6..06ec9f7d3318 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -20,7 +20,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/parser.h>
#include <linux/slab.h>
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 6ff706760676..33a9ac6f2d55 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -21,7 +21,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/parser.h>
#include <linux/semaphore.h>
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index e757f0601304..19bccfa0d593 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -22,7 +22,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/highmem.h>
#include <linux/slab.h>
--
2.34.1

2022-11-27 16:10:52

by Christian Schoenebeck

Subject: Re: [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory

On Sunday, November 27, 2022 3:46:45 PM CET Christophe JAILLET wrote:
> The 9p net files don't use IDR or IDA functionalities. So there is no point
> in including <linux/idr.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>
> ---

Reviewed-by: Christian Schoenebeck <[email protected]>

> net/9p/trans_fd.c | 1 -
> net/9p/trans_rdma.c | 1 -
> net/9p/trans_virtio.c | 1 -
> 3 files changed, 3 deletions(-)

2022-12-02 15:07:01

by Dominique Martinet

Subject: Re: [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory

Christophe JAILLET wrote on Sun, Nov 27, 2022 at 03:46:45PM +0100:
> The 9p net files don't use IDR or IDA functionalities. So there is no point
> in including <linux/idr.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <[email protected]>

Thanks, picked this one up as well

--
Dominique