2023-08-11 18:06:50

by Konrad Dybcio

[permalink] [raw]
Subject: [PATCH] clk: qcom: gcc-sm8450: Use floor ops for SDCC RCGs

Use the floor ops to prevent warnings like this at suspend exit and boot:

mmc0: Card appears overclocked; req 800000 Hz, actual 25000000 Hz

Fixes: db0c944ee92b ("clk: qcom: Add clock driver for SM8450")
Signed-off-by: Konrad Dybcio <[email protected]>
---
drivers/clk/qcom/gcc-sm8450.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gcc-sm8450.c b/drivers/clk/qcom/gcc-sm8450.c
index 86ad085260db..563542982551 100644
--- a/drivers/clk/qcom/gcc-sm8450.c
+++ b/drivers/clk/qcom/gcc-sm8450.c
@@ -936,7 +936,7 @@ static struct clk_rcg2 gcc_sdcc2_apps_clk_src = {
.parent_data = gcc_parent_data_7,
.num_parents = ARRAY_SIZE(gcc_parent_data_7),
.flags = CLK_SET_RATE_PARENT,
- .ops = &clk_rcg2_ops,
+ .ops = &clk_rcg2_floor_ops,
},
};

@@ -959,7 +959,7 @@ static struct clk_rcg2 gcc_sdcc4_apps_clk_src = {
.parent_data = gcc_parent_data_0,
.num_parents = ARRAY_SIZE(gcc_parent_data_0),
.flags = CLK_SET_RATE_PARENT,
- .ops = &clk_rcg2_ops,
+ .ops = &clk_rcg2_floor_ops,
},
};


---
base-commit: 21ef7b1e17d039053edaeaf41142423810572741
change-id: 20230811-topic-8450_clk-8a8106deda49

Best regards,
--
Konrad Dybcio <[email protected]>



2023-08-13 15:33:17

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: gcc-sm8450: Use floor ops for SDCC RCGs

On 11-08-23, 19:35, Konrad Dybcio wrote:
> Use the floor ops to prevent warnings like this at suspend exit and boot:
>
> mmc0: Card appears overclocked; req 800000 Hz, actual 25000000 Hz

Reviewed-by: Vinod Koul <[email protected]>

--
~Vinod

2023-08-14 06:11:21

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] clk: qcom: gcc-sm8450: Use floor ops for SDCC RCGs


On Fri, 11 Aug 2023 19:35:53 +0200, Konrad Dybcio wrote:
> Use the floor ops to prevent warnings like this at suspend exit and boot:
>
> mmc0: Card appears overclocked; req 800000 Hz, actual 25000000 Hz
>
>

Applied, thanks!

[1/1] clk: qcom: gcc-sm8450: Use floor ops for SDCC RCGs
commit: a27ac3806b0a0e6954fb5967223b8635242e5b8f

Best regards,
--
Bjorn Andersson <[email protected]>