2023-08-10 09:10:31

by Zhiguo Niu

Subject: [PATCH] f2fs: should update REQ_TIME for direct write

The sending interval of discard and GC should also
consider direct write requests; filesystem is not
idle if there is direct write.

Signed-off-by: Zhiguo Niu <[email protected]>
---
fs/f2fs/file.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 5ac53d2627d2..713a2d98728a 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -4537,6 +4537,7 @@ static int f2fs_dio_write_end_io(struct kiocb *iocb, ssize_t size, int error,
dec_page_count(sbi, F2FS_DIO_WRITE);
if (error)
return error;
+ f2fs_update_time(sbi, REQ_TIME);
f2fs_update_iostat(sbi, NULL, APP_DIRECT_IO, size);
return 0;
}
--
2.37.3

2023-08-13 02:16:52

by Chao Yu

Subject: Re: [PATCH] f2fs: should update REQ_TIME for direct write

On 2023/8/10 16:40, Zhiguo Niu wrote:
> The sending interval of discard and GC should also
> consider direct write requests; filesystem is not
> idle if there is direct write.
>
> Signed-off-by: Zhiguo Niu <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,

2023-08-14 21:25:00

by patchwork-bot+f2fs

Subject: Re: [f2fs-dev] [PATCH] f2fs: should update REQ_TIME for direct write

Hello:

This patch was applied to jaegeuk/f2fs.git (dev)
by Jaegeuk Kim <[email protected]>:

On Thu, 10 Aug 2023 16:40:00 +0800 you wrote:
> The sending interval of discard and GC should also
> consider direct write requests; filesystem is not
> idle if there is direct write.
>
> Signed-off-by: Zhiguo Niu <[email protected]>
> ---
> fs/f2fs/file.c | 1 +
> 1 file changed, 1 insertion(+)

Here is the summary with links:
- [f2fs-dev] f2fs: should update REQ_TIME for direct write
https://git.kernel.org/jaegeuk/f2fs/c/0cc81b1ad512

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html