2023-09-14 01:18:42

by Kemeng Shi

Subject: [PATCH] block: correct stale comment in rq_qos_wait

The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
token. Just replace stale wbt_wake_function with rq_qos_wake_function in
comment.

Signed-off-by: Kemeng Shi <[email protected]>
---
block/blk-rq-qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/blk-rq-qos.c b/block/blk-rq-qos.c
index 167be74df4ee..dd7310c94713 100644
--- a/block/blk-rq-qos.c
+++ b/block/blk-rq-qos.c
@@ -270,7 +270,7 @@ void rq_qos_wait(struct rq_wait *rqw, void *private_data,
finish_wait(&rqw->wait, &data.wq);

/*
- * We raced with wbt_wake_function() getting a token,
+ * We raced with rq_qos_wake_function() getting a token,
* which means we now have two. Put our local token
* and wake anyone else potentially waiting for one.
*/
--
2.30.0

2023-09-18 22:36:41

by Jens Axboe

Subject: Re: [PATCH] block: correct stale comment in rq_qos_wait

On Thu, 14 Sep 2023 17:15:08 +0800, Kemeng Shi wrote:
> The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
> token. Just replace stale wbt_wake_function with rq_qos_wake_function in
> comment.
>
>

Applied, thanks!

[1/1] block: correct stale comment in rq_qos_wait
commit: e599ed7866cd804ca15de7a92f7f629944cc278d

Best regards,
--
Jens Axboe

2023-09-19 02:30:30

by Tejun Heo

Subject: Re: [PATCH] block: correct stale comment in rq_qos_wait

On Thu, Sep 14, 2023 at 05:15:08PM +0800, Kemeng Shi wrote:
> The rq_qos_wait calls common wake-up function rq_qos_wake_function to get
> token. Just replace stale wbt_wake_function with rq_qos_wake_function in
> comment.
>
> Signed-off-by: Kemeng Shi <[email protected]>

Acked-by: Tejun Heo <[email protected]>

Thanks.

--
tejun