2023-07-21 17:25:34

by Bjorn Andersson

Subject: [PATCH] soundwire: qcom: Log clk_get("iface") failures

Failing to acquire the iface clock makes probing of the Qualcomm
SoundWire driver fail without providing any indication to the user. Make
the driver log the error to aid debugging system configuration issues.

Signed-off-by: Bjorn Andersson <[email protected]>
---
drivers/soundwire/qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
index 55be9f4b8d59..e51b1dfce82d 100644
--- a/drivers/soundwire/qcom.c
+++ b/drivers/soundwire/qcom.c
@@ -1550,7 +1550,7 @@ static int qcom_swrm_probe(struct platform_device *pdev)

ctrl->hclk = devm_clk_get(dev, "iface");
if (IS_ERR(ctrl->hclk)) {
- ret = PTR_ERR(ctrl->hclk);
+ ret = dev_err_probe(dev, PTR_ERR(ctrl->hclk), "unable to get iface clock\n");
goto err_init;
}

--
2.25.1

2023-07-21 21:22:35

by Andrew Halaney

Subject: Re: [PATCH] soundwire: qcom: Log clk_get("iface") failures

On Fri, Jul 21, 2023 at 09:49:01AM -0700, Bjorn Andersson wrote:
> Failing to acquire the iface clock makes probing of the Qualcomm
> SoundWire driver fail without providing any indication to the user. Make
> the driver log the error to aid debugging system configuration issues.
>
> Signed-off-by: Bjorn Andersson <[email protected]>

Reviewed-by: Andrew Halaney <[email protected]>

> ---
> drivers/soundwire/qcom.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/qcom.c b/drivers/soundwire/qcom.c
> index 55be9f4b8d59..e51b1dfce82d 100644
> --- a/drivers/soundwire/qcom.c
> +++ b/drivers/soundwire/qcom.c
> @@ -1550,7 +1550,7 @@ static int qcom_swrm_probe(struct platform_device *pdev)
>
> ctrl->hclk = devm_clk_get(dev, "iface");
> if (IS_ERR(ctrl->hclk)) {
> - ret = PTR_ERR(ctrl->hclk);
> + ret = dev_err_probe(dev, PTR_ERR(ctrl->hclk), "unable to get iface clock\n");
> goto err_init;
> }
>
> --
> 2.25.1
>

2023-09-21 17:37:20

by Vinod Koul

Subject: Re: [PATCH] soundwire: qcom: Log clk_get("iface") failures

On Fri, 21 Jul 2023 09:49:01 -0700, Bjorn Andersson wrote:
> Failing to acquire the iface clock makes probing of the Qualcomm
> SoundWire driver fail without providing any indication to the user. Make
> the driver log the error to aid debugging system configuration issues.
>
>

Applied, thanks!

[1/1] soundwire: qcom: Log clk_get("iface") failures
commit: 95b0f3aa71eb09d067d89395fdb7f2dd87feae18

Best regards,
--
~Vinod