2023-09-14 21:59:40

by Ilpo Järvinen

Subject: [PATCH v2 00/10] PCI/treewide: PCIe capability access cleanups

Instead of custom code to extract the PCIe capabilities, make the code
more obvious using FIELD_GET/PREP().

Also cleanup some duplicated defines in e1000e.

I've only put Jonathan's Reviewed-by to patches I didn't modify
significantly.

This is just a step into the right direction, there's plenty of places
still to cleanup which will have to wait for another patch series.

v2:
- Remove extract_width() and use FIELD_GET() directly (IB/hfi1)
- Convert other fields beside Link Width ones
- Remove useless u8 casts (scsi: esas2r)
- e1000e:
- Remove defines that duplicate pci_regs.h ones
- Convert to pcie_capability_read_word()

Ilpo Järvinen (10):
IB/hfi1: Use FIELD_GET() to extract Link Width
media: cobalt: Use FIELD_GET() to extract Link Width
igb: Use FIELD_GET() to extract Link Width
PCI: tegra194: Use FIELD_GET()/FIELD_PREP() with Link Width fields
PCI: mvebu: Use FIELD_PREP() with Link Width
PCI: Use FIELD_GET() to extract Link Width
scsi: esas2r: Use FIELD_GET() to extract PCIe capability fields
scsi: qla2xxx: Use FIELD_GET() to extract PCIe capability fields
e1000e: Use PCI_EXP_LNKSTA_NLW & FIELD_GET() instead of custom
defines/code
e1000e: Use pcie_capability_read_word() for reading LNKSTA

drivers/infiniband/hw/hfi1/pcie.c | 9 ++-------
drivers/media/pci/cobalt/cobalt-driver.c | 11 ++++++-----
drivers/net/ethernet/intel/e1000e/defines.h | 3 ---
drivers/net/ethernet/intel/e1000e/mac.c | 17 ++++++++---------
drivers/net/ethernet/intel/igb/e1000_mac.c | 6 +++---
drivers/pci/controller/dwc/pcie-tegra194.c | 9 ++++-----
drivers/pci/controller/pci-mvebu.c | 2 +-
drivers/pci/pci-sysfs.c | 5 ++---
drivers/pci/pci.c | 6 +++---
drivers/scsi/esas2r/esas2r_ioctl.c | 16 ++++++----------
drivers/scsi/qla2xxx/qla_os.c | 5 +++--
11 files changed, 38 insertions(+), 51 deletions(-)

--
2.30.2

2023-09-22 04:46:10

by Martin K. Petersen

Subject: Re: (subset) [PATCH v2 00/10] PCI/treewide: PCIe capability access cleanups

On Wed, 13 Sep 2023 15:27:38 +0300, Ilpo Järvinen wrote:

> Instead of custom code to extract the PCIe capabilities, make the code
> more obvious using FIELD_GET/PREP().
>
> Also cleanup some duplicated defines in e1000e.
>
> I've only put Jonathan's Reviewed-by to patches I didn't modify
> significantly.
>
> [...]

Applied to 6.7/scsi-queue, thanks!

[07/10] scsi: esas2r: Use FIELD_GET() to extract PCIe capability fields
https://git.kernel.org/mkp/scsi/c/5532f2495150
[08/10] scsi: qla2xxx: Use FIELD_GET() to extract PCIe capability fields
https://git.kernel.org/mkp/scsi/c/dc1d7b363301

--
Martin K. Petersen Oracle Linux Engineering