2023-09-26 04:09:00

by Randy Dunlap

Subject: [PATCH] block: fix kernel-doc for disk_force_media_change()

Drop one function parameter's kernel-doc comment since the parameter
was removed. This prevents a kernel-doc warning:

block/disk-events.c:300: warning: Excess function parameter 'events' description in 'disk_force_media_change'

Fixes: ab6860f62bfe ("block: simplify the disk_force_media_change interface")
Signed-off-by: Randy Dunlap <[email protected]>
Reported-by: kernel test robot <[email protected]>
Closes: lore.kernel.org/r/[email protected]
Cc: Christoph Hellwig <[email protected]>
Cc: Jens Axboe <[email protected]>
Cc: [email protected]
---
block/disk-events.c | 1 -
1 file changed, 1 deletion(-)

diff -- a/block/disk-events.c b/block/disk-events.c
--- a/block/disk-events.c
+++ b/block/disk-events.c
@@ -290,7 +290,6 @@ EXPORT_SYMBOL(disk_check_media_change);
/**
* disk_force_media_change - force a media change event
* @disk: the disk which will raise the event
- * @events: the events to raise
*
* Should be called when the media changes for @disk. Generates a uevent
* and attempts to free all dentries and inodes and invalidates all block

2023-09-26 06:06:20

by Christoph Hellwig

Subject: Re: [PATCH] block: fix kernel-doc for disk_force_media_change()

Looks good:

Reviewed-by: Christoph Hellwig <[email protected]>

2023-09-26 08:04:22

by Jens Axboe

Subject: Re: [PATCH] block: fix kernel-doc for disk_force_media_change()

On Mon, 25 Sep 2023 17:52:32 -0700, Randy Dunlap wrote:
> Drop one function parameter's kernel-doc comment since the parameter
> was removed. This prevents a kernel-doc warning:
>
> block/disk-events.c:300: warning: Excess function parameter 'events' description in 'disk_force_media_change'
>
>

Applied, thanks!

[1/1] block: fix kernel-doc for disk_force_media_change()
commit: a578a25339aca38e23bb5af6e3fc6c2c51f0215c

Best regards,
--
Jens Axboe