2023-09-20 13:59:17

by Ravi Gunasekaran

[permalink] [raw]
Subject: [PATCH v2] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander

AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
The expander at address 0x38 is used to detect daughter cards.
Add a node for this I/O expander.

Signed-off-by: Ravi Gunasekaran <[email protected]>
---
Changes from v1:
---------------
* Moved the expander node @38 to appear before the one at address 39.
* Removed the label pca9554_1 for the node as it is not used.

v1: https://lore.kernel.org/all/[email protected]/

arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
index f5c26e9fba98..1637ec5ab5ed 100644
--- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
@@ -369,6 +369,13 @@
ti,enable-vout-discharge;
};

+ gpio@38 {
+ compatible = "nxp,pca9554";
+ reg = <0x38>;
+ gpio-controller;
+ #gpio-cells = <2>;
+ };
+
pca9554: gpio@39 {
compatible = "nxp,pca9554";
reg = <0x39>;

base-commit: dfa449a58323de195773cf928d99db4130702bf7
--
2.17.1


2023-09-20 14:33:44

by Andrew Davis

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander

On 9/20/23 12:38 AM, Ravi Gunasekaran wrote:
> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
> The expander at address 0x38 is used to detect daughter cards.
> Add a node for this I/O expander.
>
> Signed-off-by: Ravi Gunasekaran <[email protected]>
> ---
> Changes from v1:
> ---------------
> * Moved the expander node @38 to appear before the one at address 39.
> * Removed the label pca9554_1 for the node as it is not used.
>

LGTM,

Reviewed-by: Andrew Davis <[email protected]>

> v1: https://lore.kernel.org/all/[email protected]/
>
> arch/arm64/boot/dts/ti/k3-am654-base-board.dts | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> index f5c26e9fba98..1637ec5ab5ed 100644
> --- a/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am654-base-board.dts
> @@ -369,6 +369,13 @@
> ti,enable-vout-discharge;
> };
>
> + gpio@38 {
> + compatible = "nxp,pca9554";
> + reg = <0x38>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + };
> +
> pca9554: gpio@39 {
> compatible = "nxp,pca9554";
> reg = <0x39>;
>
> base-commit: dfa449a58323de195773cf928d99db4130702bf7

2023-10-03 11:03:56

by Vignesh Raghavendra

[permalink] [raw]
Subject: Re: [PATCH v2] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander

Hi Ravi Gunasekaran,

On Wed, 20 Sep 2023 11:08:34 +0530, Ravi Gunasekaran wrote:
> AM654 baseboard has two TCA9554 I/O expander on the WKUP_I2C0 bus.
> The expander at address 0x38 is used to detect daughter cards.
> Add a node for this I/O expander.
>
>

I have applied the following to branch ti-k3-dts-next on [1].
Thank you!

[1/1] arm64: dts: ti: k3-am654-base-board: Add I2C I/O expander
commit: 2f40c6df3dcc1341afd99cd1a4de035f807c8a03

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh