2023-10-05 17:03:09

by Florian Fainelli

[permalink] [raw]
Subject: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value

Check the clk_prepare_enable() return value and propagate it.

Suggested-by: Uwe Kleine-König <[email protected]>
Signed-off-by: Florian Fainelli <[email protected]>
---
This change depends upon:

https://lore.kernel.org/all/[email protected]/

drivers/pwm/pwm-brcmstb.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-brcmstb.c b/drivers/pwm/pwm-brcmstb.c
index a7d529bf76ad..de9cbda2e4ff 100644
--- a/drivers/pwm/pwm-brcmstb.c
+++ b/drivers/pwm/pwm-brcmstb.c
@@ -297,9 +297,7 @@ static int brcmstb_pwm_resume(struct device *dev)
{
struct brcmstb_pwm *p = dev_get_drvdata(dev);

- clk_prepare_enable(p->clk);
-
- return 0;
+ return clk_prepare_enable(p->clk);
}
#endif

--
2.34.1


Attachments:
smime.p7s (4.12 kB)
S/MIME Cryptographic Signature

2023-10-09 10:02:00

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value

On Thu, Oct 05, 2023 at 09:47:27AM -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
>
> Suggested-by: Uwe Kleine-K?nig <[email protected]>
> Signed-off-by: Florian Fainelli <[email protected]>

Reviewed-by: Uwe Kleine-K?nig <[email protected]>

Thanks
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (510.00 B)
signature.asc (499.00 B)
Download all attachments

2023-10-12 13:56:28

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] pwm: brcmstb: Checked clk_prepare_enable() return value


On Thu, 05 Oct 2023 09:47:27 -0700, Florian Fainelli wrote:
> Check the clk_prepare_enable() return value and propagate it.
>
>

Applied, thanks!

[1/1] pwm: brcmstb: Checked clk_prepare_enable() return value
commit: d559f11591900a283b2a0b1087d68992e6c2062a

Best regards,
--
Thierry Reding <[email protected]>