2023-10-23 14:17:57

by Colin Ian King

Subject: [PATCH] RDMA/hfi1: remove redundant assignment to pointer ppd

Pointer ppd is being assigned a value in a for-loop however it
is never read. The assignment is redundant and can be removed.
Cleans up clang scan build warning:

drivers/infiniband/hw/hfi1/init.c:1030:3: warning: Value stored
to 'ppd' is never read [deadcode.DeadStores]

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/infiniband/hw/hfi1/init.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/infiniband/hw/hfi1/init.c b/drivers/infiniband/hw/hfi1/init.c
index 5ce2215e09c2..cbac4a442d9e 100644
--- a/drivers/infiniband/hw/hfi1/init.c
+++ b/drivers/infiniband/hw/hfi1/init.c
@@ -1027,7 +1027,6 @@ static void shutdown_device(struct hfi1_devdata *dd)
msix_clean_up_interrupts(dd);

for (pidx = 0; pidx < dd->num_pports; ++pidx) {
- ppd = dd->pport + pidx;
for (i = 0; i < dd->num_rcv_contexts; i++) {
rcd = hfi1_rcd_get_by_index(dd, i);
hfi1_rcvctrl(dd, HFI1_RCVCTRL_TAILUPD_DIS |
--
2.39.2

2023-10-24 15:16:56

by Leon Romanovsky

Subject: Re: [PATCH] RDMA/hfi1: remove redundant assignment to pointer ppd

On Mon, 23 Oct 2023 15:17:33 +0100, Colin Ian King wrote:
> Pointer ppd is being assigned a value in a for-loop however it
> is never read. The assignment is redundant and can be removed.
> Cleans up clang scan build warning:
>
> drivers/infiniband/hw/hfi1/init.c:1030:3: warning: Value stored
> to 'ppd' is never read [deadcode.DeadStores]
>
> [...]

Applied, thanks!

[1/1] RDMA/hfi1: remove redundant assignment to pointer ppd
https://git.kernel.org/rdma/rdma/c/b55706366c5ed6

Best regards,
--
Leon Romanovsky <[email protected]>