2023-10-20 09:20:03

by Su Hui

Subject: [PATCH] leds: lp5521: add an error check in lp5521_post_init_device

lp55xx_write() can return an error code, add a check for this.

Signed-off-by: Su Hui <[email protected]>
---
drivers/leds/leds-lp5521.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/leds/leds-lp5521.c b/drivers/leds/leds-lp5521.c
index 2ef19ad23b1d..f9c8b568b652 100644
--- a/drivers/leds/leds-lp5521.c
+++ b/drivers/leds/leds-lp5521.c
@@ -301,6 +301,8 @@ static int lp5521_post_init_device(struct lp55xx_chip *chip)

/* Set all PWMs to direct control mode */
ret = lp55xx_write(chip, LP5521_REG_OP_MODE, LP5521_CMD_DIRECT);
+ if (ret)
+ return ret;

/* Update configuration for the clock setting */
val = LP5521_DEFAULT_CFG;
--
2.30.2

2023-10-25 10:42:25

by Lee Jones

Subject: Re: (subset) [PATCH] leds: lp5521: add an error check in lp5521_post_init_device

On Fri, 20 Oct 2023 17:19:31 +0800, Su Hui wrote:
> lp55xx_write() can return an error code, add a check for this.
>
>

Applied, thanks!

[1/1] leds: lp5521: add an error check in lp5521_post_init_device
commit: 13f0ccb77e98cc82c04db2c5fab984865666285e

--
Lee Jones [李琼斯]