2023-10-23 20:26:56

by Nik Bune

[permalink] [raw]
Subject: [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml

Convert txt file to yaml.
Add maintainers list.

Signed-off-by: Nik Bune <[email protected]>
---

Changes in v2 (according to review comments):
- Updated clocks property to have only maxItems without $ref and description.
- Removed timeout-sec explicit definition, as it is defined in watchdog.yaml.

v1 patch: https://lore.kernel.org/all/[email protected]/

.../bindings/watchdog/cnxt,cx92755-wdt.yaml | 45 +++++++++++++++++++
.../bindings/watchdog/digicolor-wdt.txt | 25 -----------
2 files changed, 45 insertions(+), 25 deletions(-)
create mode 100644 Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
delete mode 100644 Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt

diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
new file mode 100644
index 000000000000..1844d7e026fe
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
@@ -0,0 +1,45 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/cnxt,cx92755-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Conexant Digicolor SoCs Watchdog timer
+
+description: |
+ The watchdog functionality in Conexant Digicolor SoCs relies on the so called
+ "Agent Communication" block. This block includes the eight programmable system
+ timer counters. The first timer (called "Timer A") is the only one that can be
+ used as watchdog.
+
+allOf:
+ - $ref: watchdog.yaml#
+
+maintainers:
+ - Baruch Siach <[email protected]>
+
+properties:
+ compatible:
+ const: cnxt,cx92755-wdt
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - clocks
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ watchdog@f0000fc0 {
+ compatible = "cnxt,cx92755-wdt";
+ reg = <0xf0000fc0 0x8>;
+ clocks = <&main_clk>;
+ timeout-sec = <15>;
+ };
diff --git a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt b/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
deleted file mode 100644
index a882967e17d4..000000000000
--- a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
+++ /dev/null
@@ -1,25 +0,0 @@
-Conexant Digicolor SoCs Watchdog timer
-
-The watchdog functionality in Conexant Digicolor SoCs relies on the so called
-"Agent Communication" block. This block includes the eight programmable system
-timer counters. The first timer (called "Timer A") is the only one that can be
-used as watchdog.
-
-Required properties:
-
-- compatible : Should be "cnxt,cx92755-wdt"
-- reg : Specifies base physical address and size of the registers
-- clocks : phandle; specifies the clock that drives the timer
-
-Optional properties:
-
-- timeout-sec : Contains the watchdog timeout in seconds
-
-Example:
-
- watchdog@f0000fc0 {
- compatible = "cnxt,cx92755-wdt";
- reg = <0xf0000fc0 0x8>;
- clocks = <&main_clk>;
- timeout-sec = <15>;
- };
--
2.34.1


2023-10-24 07:40:11

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml

On 23/10/2023 22:26, Nik Bune wrote:
> Convert txt file to yaml.
> Add maintainers list.
>
> Signed-off-by: Nik Bune <[email protected]>
> ---
>

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-10-24 18:06:04

by Guenter Roeck

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml

On Mon, Oct 23, 2023 at 10:26:22PM +0200, Nik Bune wrote:
> Convert txt file to yaml.
> Add maintainers list.
>
> Signed-off-by: Nik Bune <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> Changes in v2 (according to review comments):
> - Updated clocks property to have only maxItems without $ref and description.
> - Removed timeout-sec explicit definition, as it is defined in watchdog.yaml.
>
> v1 patch: https://lore.kernel.org/all/[email protected]/
>
> .../bindings/watchdog/cnxt,cx92755-wdt.yaml | 45 +++++++++++++++++++
> .../bindings/watchdog/digicolor-wdt.txt | 25 -----------
> 2 files changed, 45 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
>
> diff --git a/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> new file mode 100644
> index 000000000000..1844d7e026fe
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> @@ -0,0 +1,45 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/cnxt,cx92755-wdt.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Conexant Digicolor SoCs Watchdog timer
> +
> +description: |
> + The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> + "Agent Communication" block. This block includes the eight programmable system
> + timer counters. The first timer (called "Timer A") is the only one that can be
> + used as watchdog.
> +
> +allOf:
> + - $ref: watchdog.yaml#
> +
> +maintainers:
> + - Baruch Siach <[email protected]>
> +
> +properties:
> + compatible:
> + const: cnxt,cx92755-wdt
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + watchdog@f0000fc0 {
> + compatible = "cnxt,cx92755-wdt";
> + reg = <0xf0000fc0 0x8>;
> + clocks = <&main_clk>;
> + timeout-sec = <15>;
> + };
> diff --git a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt b/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> deleted file mode 100644
> index a882967e17d4..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
> +++ /dev/null
> @@ -1,25 +0,0 @@
> -Conexant Digicolor SoCs Watchdog timer
> -
> -The watchdog functionality in Conexant Digicolor SoCs relies on the so called
> -"Agent Communication" block. This block includes the eight programmable system
> -timer counters. The first timer (called "Timer A") is the only one that can be
> -used as watchdog.
> -
> -Required properties:
> -
> -- compatible : Should be "cnxt,cx92755-wdt"
> -- reg : Specifies base physical address and size of the registers
> -- clocks : phandle; specifies the clock that drives the timer
> -
> -Optional properties:
> -
> -- timeout-sec : Contains the watchdog timeout in seconds
> -
> -Example:
> -
> - watchdog@f0000fc0 {
> - compatible = "cnxt,cx92755-wdt";
> - reg = <0xf0000fc0 0x8>;
> - clocks = <&main_clk>;
> - timeout-sec = <15>;
> - };
> --
> 2.34.1
>

2023-10-25 20:02:14

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH v2] dt-bindings: watchdog: cnxt,cx92755-wdt: convert txt to yaml


On Mon, 23 Oct 2023 22:26:22 +0200, Nik Bune wrote:
> Convert txt file to yaml.
> Add maintainers list.
>
> Signed-off-by: Nik Bune <[email protected]>
> ---
>
> Changes in v2 (according to review comments):
> - Updated clocks property to have only maxItems without $ref and description.
> - Removed timeout-sec explicit definition, as it is defined in watchdog.yaml.
>
> v1 patch: https://lore.kernel.org/all/[email protected]/
>
> .../bindings/watchdog/cnxt,cx92755-wdt.yaml | 45 +++++++++++++++++++
> .../bindings/watchdog/digicolor-wdt.txt | 25 -----------
> 2 files changed, 45 insertions(+), 25 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/watchdog/cnxt,cx92755-wdt.yaml
> delete mode 100644 Documentation/devicetree/bindings/watchdog/digicolor-wdt.txt
>

It seems watchdog bindings aren't getting applied, so I've applied it.
Wim, please take watchdog bindings in the future unless noted otherwise.

Rob