2023-10-27 18:33:20

by Pandey, Radhey Shyam

[permalink] [raw]
Subject: [PATCH] soc: xilinx: fix unhandled SGI warning message

From: Tanmay Shah <[email protected]>

Xen broadcasts SGI to each VM when multiple VMs run on Xen hypervisor. In
such case spurious SGI is expected if one event is registered by one VM and
not registered by another VM. We let users know that Unhandled SGI is not
error and expected if kernel is running on Xen hypervisor.

Signed-off-by: Tanmay Shah <[email protected]>
Signed-off-by: Radhey Shyam Pandey <[email protected]>
---
drivers/soc/xilinx/xlnx_event_manager.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c
index 86a048a10a13..6356b80ce57b 100644
--- a/drivers/soc/xilinx/xlnx_event_manager.c
+++ b/drivers/soc/xilinx/xlnx_event_manager.c
@@ -477,7 +477,7 @@ static void xlnx_call_notify_cb_handler(const u32 *payload)
}
}
if (!is_callback_found)
- pr_warn("Didn't find any registered callback for 0x%x 0x%x\n",
+ pr_warn("Unhandled SGI node 0x%x event 0x%x. Expected with Xen hypervisor\n",
payload[1], payload[2]);
}

--
2.1.1


2023-11-15 14:06:00

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] soc: xilinx: fix unhandled SGI warning message



On 10/27/23 20:23, Radhey Shyam Pandey wrote:
> From: Tanmay Shah <[email protected]>
>
> Xen broadcasts SGI to each VM when multiple VMs run on Xen hypervisor. In
> such case spurious SGI is expected if one event is registered by one VM and
> not registered by another VM. We let users know that Unhandled SGI is not
> error and expected if kernel is running on Xen hypervisor.
>
> Signed-off-by: Tanmay Shah <[email protected]>
> Signed-off-by: Radhey Shyam Pandey <[email protected]>
> ---
> drivers/soc/xilinx/xlnx_event_manager.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/xilinx/xlnx_event_manager.c b/drivers/soc/xilinx/xlnx_event_manager.c
> index 86a048a10a13..6356b80ce57b 100644
> --- a/drivers/soc/xilinx/xlnx_event_manager.c
> +++ b/drivers/soc/xilinx/xlnx_event_manager.c
> @@ -477,7 +477,7 @@ static void xlnx_call_notify_cb_handler(const u32 *payload)
> }
> }
> if (!is_callback_found)
> - pr_warn("Didn't find any registered callback for 0x%x 0x%x\n",
> + pr_warn("Unhandled SGI node 0x%x event 0x%x. Expected with Xen hypervisor\n",
> payload[1], payload[2]);
> }
>

Applied.
M