2023-10-27 10:25:07

by Herve Codina

Subject: [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS

of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.

Return early in of_unittest_check_addr() to avoid the
of_address_to_resource() usage.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Signed-off-by: Herve Codina <[email protected]>
---
Rob,

This fixes a patch you already applied from my series
https://lore.kernel.org/all/[email protected]/

I don't know if it's too late or not but maybe you can squash this fix patch.

My apologies for this issue.

Hervé

drivers/of/unittest.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index ffbecd349899..e9e90e96600e 100644
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1201,6 +1201,9 @@ static void __init of_unittest_check_addr(const char *node_path,
unsigned int count;
int ret;

+ if (!IS_ENABLED(CONFIG_OF_ADDRESS))
+ return;
+
np = of_find_node_by_path(node_path);
if (!np) {
pr_err("missing testcase data (%s)\n", node_path);
--
2.41.0

2023-10-27 21:38:40

by Rob Herring (Arm)

Subject: Re: [PATCH 1/1] of: unittest: Fix test build on config without CONFIG_OF_ADDRESS

On Fri, 27 Oct 2023 12:24:37 +0200, Herve Codina wrote:
> of_address_to_resource() is not defined if !CONFIG_OF_ADDRESS.
>
> Return early in of_unittest_check_addr() to avoid the
> of_address_to_resource() usage.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Signed-off-by: Herve Codina <[email protected]>
> ---
> Rob,
>
> This fixes a patch you already applied from my series
> https://lore.kernel.org/all/[email protected]/
>
> I don't know if it's too late or not but maybe you can squash this fix patch.
>
> My apologies for this issue.
>
> Herv?
>
> drivers/of/unittest.c | 3 +++
> 1 file changed, 3 insertions(+)
>

Squashed and applied, thanks!