2018-05-30 22:06:16

by Jeffrin Jose T

Subject: [RESEND PATCH] selftests: intel_pstate: notification about privilege required to run intel_pstate testing script

The intel_pstate related testing script need root level privileges
when trying to access certain file for the successful execution of
the script.But this is not the case always like when using evaluation
only mode, which only require user level privilege.

This patch is to notify the user about the privilege the script
demands for the successful execution of the test.

Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>
---
tools/testing/selftests/intel_pstate/run.sh | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
index 8576f6564307..e7008f614ad7 100755
--- a/tools/testing/selftests/intel_pstate/run.sh
+++ b/tools/testing/selftests/intel_pstate/run.sh
@@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
exit $ksft_skip
fi

+msg="skip all tests:"
+if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
+ echo $msg please run this as root >&2
+ exit $ksft_skip
+fi
+
max_cpus=$(($(nproc)-1))

function run_test () {
--
2.17.0

2018-05-30 23:43:53

by Shuah Khan

Subject: Re: [RESEND PATCH] selftests: intel_pstate: notification about privilege required to run intel_pstate testing script

On 05/30/2018 04:03 PM, Jeffrin Jose T wrote:
> The intel_pstate related testing script need root level privileges
> when trying to access certain file for the successful execution of
> the script.But this is not the case always like when using evaluation
> only mode, which only require user level privilege.
>
> This patch is to notify the user about the privilege the script
> demands for the successful execution of the test.
>
> Signed-off-by: Jeffrin Jose T (Rajagiri SET) <[email protected]>
> ---

I will take this patch and apply it to linux-kselftest next for 4.18-rc1.

For next time, this patch should have been tagged v2 not RESEND. Also please
include changes made since the last version in this spot after the Signed-off-by
line.

> tools/testing/selftests/intel_pstate/run.sh | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/intel_pstate/run.sh b/tools/testing/selftests/intel_pstate/run.sh
> index 8576f6564307..e7008f614ad7 100755
> --- a/tools/testing/selftests/intel_pstate/run.sh
> +++ b/tools/testing/selftests/intel_pstate/run.sh
> @@ -38,6 +38,12 @@ if ! uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ | grep -q x86; then
> exit $ksft_skip
> fi
>
> +msg="skip all tests:"
> +if [ $UID != 0 ] && [ $EVALUATE_ONLY == 0 ]; then
> + echo $msg please run this as root >&2
> + exit $ksft_skip
> +fi
> +
> max_cpus=$(($(nproc)-1))
>
> function run_test () {
>

thanks,
-- Shuah

2018-05-31 13:05:41

by Jeffrin Jose T

Subject: Re: [RESEND PATCH] selftests: intel_pstate: notification about privilege required to run intel_pstate testing script

On Thu, May 31, 2018 at 5:12 AM, Shuah Khan <[email protected]> wrote:
> I will take this patch and apply it to linux-kselftest next for 4.18-rc1.
anyway thanks .

> For next time, this patch should have been tagged v2 not RESEND. Also please
> include changes made since the last version in this spot after the Signed-off-by
> line.
thanks for correction

--
software engineer
rajagiri school of engineering and technology