From: Rafał Miłecki <[email protected]>
This helps validating DTS files. Introduced changes:
1. Reworded title
2. Made "bus" clock required on MT7623 as well
3. Added required #include-s and adjusted "reg" & clocks in example
Signed-off-by: Rafał Miłecki <[email protected]>
---
V2: Extended "IR" in title
Made "bus" required at MT7623 needs it as well
Updated example
Thanks AngeloGioacchino!
.../bindings/media/mediatek,mt7622-cir.yaml | 55 +++++++++++++++++++
.../devicetree/bindings/media/mtk-cir.txt | 28 ----------
2 files changed, 55 insertions(+), 28 deletions(-)
create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
delete mode 100644 Documentation/devicetree/bindings/media/mtk-cir.txt
diff --git a/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
new file mode 100644
index 000000000000..c01210e053f9
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
@@ -0,0 +1,55 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek Consumer Infrared Receiver on-SoC Controller
+
+maintainers:
+ - Sean Wang <[email protected]>
+
+allOf:
+ - $ref: rc.yaml#
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt7622-cir
+ - mediatek,mt7623-cir
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ clocks:
+ maxItems: 2
+
+ clock-names:
+ items:
+ - const: clk
+ - const: bus
+
+required:
+ - reg
+ - interrupts
+ - clocks
+ - clock-names
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/mt2701-clk.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ ir@10013000 {
+ compatible = "mediatek,mt7623-cir";
+ reg = <0x10013000 0x1000>;
+ interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
+ clocks = <&infracfg CLK_INFRA_IRRX>, <&topckgen CLK_TOP_AXI_SEL>;
+ clock-names = "clk", "bus";
+ linux,rc-map-name = "rc-rc6-mce";
+ };
diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/Documentation/devicetree/bindings/media/mtk-cir.txt
deleted file mode 100644
index 5e18087ce11f..000000000000
--- a/Documentation/devicetree/bindings/media/mtk-cir.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-Device-Tree bindings for Mediatek consumer IR controller
-found in Mediatek SoC family
-
-Required properties:
-- compatible : Should be
- "mediatek,mt7623-cir": for MT7623 SoC
- "mediatek,mt7622-cir": for MT7622 SoC
-- clocks : list of clock specifiers, corresponding to
- entries in clock-names property;
-- clock-names : should contain
- - "clk" entries: for MT7623 SoC
- - "clk", "bus" entries: for MT7622 SoC
-- interrupts : should contain IR IRQ number;
-- reg : should contain IO map address for IR.
-
-Optional properties:
-- linux,rc-map-name : see rc.txt file in the same directory.
-
-Example:
-
-cir: cir@10013000 {
- compatible = "mediatek,mt7623-cir";
- reg = <0 0x10013000 0 0x1000>;
- interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
- clocks = <&infracfg CLK_INFRA_IRRX>;
- clock-names = "clk";
- linux,rc-map-name = "rc-rc6-mce";
-};
--
2.35.3
Il 09/02/24 09:56, Rafał Miłecki ha scritto:
> From: Rafał Miłecki <[email protected]>
>
> This helps validating DTS files. Introduced changes:
> 1. Reworded title
> 2. Made "bus" clock required on MT7623 as well
> 3. Added required #include-s and adjusted "reg" & clocks in example
>
> Signed-off-by: Rafał Miłecki <[email protected]>
> ---
> V2: Extended "IR" in title
> Made "bus" required at MT7623 needs it as well
> Updated example
>
> Thanks AngeloGioacchino!
You're welcome :-)
Reviewed-by: AngeloGioacchino Del Regno <[email protected]>
>
> .../bindings/media/mediatek,mt7622-cir.yaml | 55 +++++++++++++++++++
> .../devicetree/bindings/media/mtk-cir.txt | 28 ----------
> 2 files changed, 55 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/mtk-cir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> new file mode 100644
> index 000000000000..c01210e053f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Consumer Infrared Receiver on-SoC Controller
> +
> +maintainers:
> + - Sean Wang <[email protected]>
> +
> +allOf:
> + - $ref: rc.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt7622-cir
> + - mediatek,mt7623-cir
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: clk
> + - const: bus
> +
> +required:
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt2701-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + ir@10013000 {
> + compatible = "mediatek,mt7623-cir";
> + reg = <0x10013000 0x1000>;
> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg CLK_INFRA_IRRX>, <&topckgen CLK_TOP_AXI_SEL>;
> + clock-names = "clk", "bus";
> + linux,rc-map-name = "rc-rc6-mce";
> + };
> diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/Documentation/devicetree/bindings/media/mtk-cir.txt
> deleted file mode 100644
> index 5e18087ce11f..000000000000
> --- a/Documentation/devicetree/bindings/media/mtk-cir.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Device-Tree bindings for Mediatek consumer IR controller
> -found in Mediatek SoC family
> -
> -Required properties:
> -- compatible : Should be
> - "mediatek,mt7623-cir": for MT7623 SoC
> - "mediatek,mt7622-cir": for MT7622 SoC
> -- clocks : list of clock specifiers, corresponding to
> - entries in clock-names property;
> -- clock-names : should contain
> - - "clk" entries: for MT7623 SoC
> - - "clk", "bus" entries: for MT7622 SoC
> -- interrupts : should contain IR IRQ number;
> -- reg : should contain IO map address for IR.
> -
> -Optional properties:
> -- linux,rc-map-name : see rc.txt file in the same directory.
> -
> -Example:
> -
> -cir: cir@10013000 {
> - compatible = "mediatek,mt7623-cir";
> - reg = <0 0x10013000 0 0x1000>;
> - interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <&infracfg CLK_INFRA_IRRX>;
> - clock-names = "clk";
> - linux,rc-map-name = "rc-rc6-mce";
> -};
On Fri, Feb 09, 2024 at 09:56:16AM +0100, Rafał Miłecki wrote:
> + ir@10013000 {
I think I prefer "ir-receiver" as the node name, but not worth a respin
IMO.
Reviewed-by: Conor Dooley <[email protected]>
Cheers,
Conor.
Hi Mauro,
On 9.02.2024 09:56, Rafał Miłecki wrote:
> From: Rafał Miłecki <[email protected]>
>
> This helps validating DTS files. Introduced changes:
> 1. Reworded title
> 2. Made "bus" clock required on MT7623 as well
> 3. Added required #include-s and adjusted "reg" & clocks in example
>
> Signed-off-by: Rafał Miłecki <[email protected]>
could you take my patch throught your tree?
> ---
> V2: Extended "IR" in title
> Made "bus" required at MT7623 needs it as well
> Updated example
>
> Thanks AngeloGioacchino!
>
> .../bindings/media/mediatek,mt7622-cir.yaml | 55 +++++++++++++++++++
> .../devicetree/bindings/media/mtk-cir.txt | 28 ----------
> 2 files changed, 55 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> delete mode 100644 Documentation/devicetree/bindings/media/mtk-cir.txt
>
> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> new file mode 100644
> index 000000000000..c01210e053f9
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
> @@ -0,0 +1,55 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek Consumer Infrared Receiver on-SoC Controller
> +
> +maintainers:
> + - Sean Wang <[email protected]>
> +
> +allOf:
> + - $ref: rc.yaml#
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt7622-cir
> + - mediatek,mt7623-cir
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + items:
> + - const: clk
> + - const: bus
> +
> +required:
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/mt2701-clk.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + ir@10013000 {
> + compatible = "mediatek,mt7623-cir";
> + reg = <0x10013000 0x1000>;
> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&infracfg CLK_INFRA_IRRX>, <&topckgen CLK_TOP_AXI_SEL>;
> + clock-names = "clk", "bus";
> + linux,rc-map-name = "rc-rc6-mce";
> + };
> diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/Documentation/devicetree/bindings/media/mtk-cir.txt
> deleted file mode 100644
> index 5e18087ce11f..000000000000
> --- a/Documentation/devicetree/bindings/media/mtk-cir.txt
> +++ /dev/null
> @@ -1,28 +0,0 @@
> -Device-Tree bindings for Mediatek consumer IR controller
> -found in Mediatek SoC family
> -
> -Required properties:
> -- compatible : Should be
> - "mediatek,mt7623-cir": for MT7623 SoC
> - "mediatek,mt7622-cir": for MT7622 SoC
> -- clocks : list of clock specifiers, corresponding to
> - entries in clock-names property;
> -- clock-names : should contain
> - - "clk" entries: for MT7623 SoC
> - - "clk", "bus" entries: for MT7622 SoC
> -- interrupts : should contain IR IRQ number;
> -- reg : should contain IO map address for IR.
> -
> -Optional properties:
> -- linux,rc-map-name : see rc.txt file in the same directory.
> -
> -Example:
> -
> -cir: cir@10013000 {
> - compatible = "mediatek,mt7623-cir";
> - reg = <0 0x10013000 0 0x1000>;
> - interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
> - clocks = <&infracfg CLK_INFRA_IRRX>;
> - clock-names = "clk";
> - linux,rc-map-name = "rc-rc6-mce";
> -};
Hi Mauro,
On 23.04.2024 06:22, Rafał Miłecki wrote:
> On 9.02.2024 09:56, Rafał Miłecki wrote:
>> From: Rafał Miłecki <[email protected]>
>>
>> This helps validating DTS files. Introduced changes:
>> 1. Reworded title
>> 2. Made "bus" clock required on MT7623 as well
>> 3. Added required #include-s and adjusted "reg" & clocks in example
>>
>> Signed-off-by: Rafał Miłecki <[email protected]>
>
> could you take my patch throught your tree?
did you have a chance to look at this? Can you take it to your tree?
>> ---
>> V2: Extended "IR" in title
>> Made "bus" required at MT7623 needs it as well
>> Updated example
>>
>> Thanks AngeloGioacchino!
>>
>> .../bindings/media/mediatek,mt7622-cir.yaml | 55 +++++++++++++++++++
>> .../devicetree/bindings/media/mtk-cir.txt | 28 ----------
>> 2 files changed, 55 insertions(+), 28 deletions(-)
>> create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
>> delete mode 100644 Documentation/devicetree/bindings/media/mtk-cir.txt
>>
>> diff --git a/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
>> new file mode 100644
>> index 000000000000..c01210e053f9
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/mediatek,mt7622-cir.yaml
>> @@ -0,0 +1,55 @@
>> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/mediatek,mt7622-cir.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: MediaTek Consumer Infrared Receiver on-SoC Controller
>> +
>> +maintainers:
>> + - Sean Wang <[email protected]>
>> +
>> +allOf:
>> + - $ref: rc.yaml#
>> +
>> +properties:
>> + compatible:
>> + enum:
>> + - mediatek,mt7622-cir
>> + - mediatek,mt7623-cir
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 2
>> +
>> + clock-names:
>> + items:
>> + - const: clk
>> + - const: bus
>> +
>> +required:
>> + - reg
>> + - interrupts
>> + - clocks
>> + - clock-names
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/mt2701-clk.h>
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> + ir@10013000 {
>> + compatible = "mediatek,mt7623-cir";
>> + reg = <0x10013000 0x1000>;
>> + interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
>> + clocks = <&infracfg CLK_INFRA_IRRX>, <&topckgen CLK_TOP_AXI_SEL>;
>> + clock-names = "clk", "bus";
>> + linux,rc-map-name = "rc-rc6-mce";
>> + };
>> diff --git a/Documentation/devicetree/bindings/media/mtk-cir.txt b/Documentation/devicetree/bindings/media/mtk-cir.txt
>> deleted file mode 100644
>> index 5e18087ce11f..000000000000
>> --- a/Documentation/devicetree/bindings/media/mtk-cir.txt
>> +++ /dev/null
>> @@ -1,28 +0,0 @@
>> -Device-Tree bindings for Mediatek consumer IR controller
>> -found in Mediatek SoC family
>> -
>> -Required properties:
>> -- compatible : Should be
>> - "mediatek,mt7623-cir": for MT7623 SoC
>> - "mediatek,mt7622-cir": for MT7622 SoC
>> -- clocks : list of clock specifiers, corresponding to
>> - entries in clock-names property;
>> -- clock-names : should contain
>> - - "clk" entries: for MT7623 SoC
>> - - "clk", "bus" entries: for MT7622 SoC
>> -- interrupts : should contain IR IRQ number;
>> -- reg : should contain IO map address for IR.
>> -
>> -Optional properties:
>> -- linux,rc-map-name : see rc.txt file in the same directory.
>> -
>> -Example:
>> -
>> -cir: cir@10013000 {
>> - compatible = "mediatek,mt7623-cir";
>> - reg = <0 0x10013000 0 0x1000>;
>> - interrupts = <GIC_SPI 87 IRQ_TYPE_LEVEL_LOW>;
>> - clocks = <&infracfg CLK_INFRA_IRRX>;
>> - clock-names = "clk";
>> - linux,rc-map-name = "rc-rc6-mce";
>> -};
>