2019-06-02 16:01:59

by Emanuel Bennici

Subject: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message

Add a Whitespace between '-' and 'Exit' to keep the log messages consistent

Signed-off-by: Emanuel Bennici <[email protected]>
---
drivers/pci/hotplug/ibmphp_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
index 59840a094973..cd73bea12bc7 100644
--- a/drivers/pci/hotplug/ibmphp_core.c
+++ b/drivers/pci/hotplug/ibmphp_core.c
@@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
/* This is for x440, once Brandon fixes the firmware,
will not need this delay */
msleep(1000);
- debug("%s -Exit\n", __func__);
+ debug("%s - Exit\n", __func__);
return 0;
}

--
2.19.1

2019-06-02 16:18:20

by Joe Perches

Subject: Re: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message

On Sun, 2019-06-02 at 18:00 +0200, Emanuel Bennici wrote:
> Add a Whitespace between '-' and 'Exit' to keep the log messages consistent
[]
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
[]
> @@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
> /* This is for x440, once Brandon fixes the firmware,
> will not need this delay */
> msleep(1000);
> - debug("%s -Exit\n", __func__);
> + debug("%s - Exit\n", __func__);

These sorts of messages should just be deleted
and the function tracer (ftrace) used instead.