2023-10-31 18:27:28

by Elliot Berman

[permalink] [raw]
Subject: [PATCH] dt-bindings: power: reset: $ref reboot-mode in syscon-reboot-mode

syscon-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
rewrites the properties. Update so it $refs instead.

Signed-off-by: Elliot Berman <[email protected]>
---
.../devicetree/bindings/power/reset/syscon-reboot-mode.yaml | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
index 9b1ffceefe3d..b6acff199cde 100644
--- a/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
+++ b/Documentation/devicetree/bindings/power/reset/syscon-reboot-mode.yaml
@@ -29,12 +29,10 @@ properties:
$ref: /schemas/types.yaml#/definitions/uint32
description: Offset in the register map for the mode register (in bytes)

-patternProperties:
- "^mode-.+":
- $ref: /schemas/types.yaml#/definitions/uint32
- description: Vendor-specific mode value written to the mode register
+allOf:
+ - $ref: reboot-mode.yaml#

-additionalProperties: false
+unevaluatedProperties: false

required:
- compatible

---
base-commit: ffc253263a1375a65fa6c9f62a893e9767fbebfa
change-id: 20231031-ref-reboot-mode-febf88dea07b

Best regards,
--
Elliot Berman <[email protected]>


2023-11-01 15:24:56

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in syscon-reboot-mode


On Tue, 31 Oct 2023 11:27:00 -0700, Elliot Berman wrote:
> syscon-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
> Signed-off-by: Elliot Berman <[email protected]>
> ---
> .../devicetree/bindings/power/reset/syscon-reboot-mode.yaml | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>

Reviewed-by: Rob Herring <[email protected]>

2023-11-16 00:39:25

by Sebastian Reichel

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: power: reset: $ref reboot-mode in syscon-reboot-mode


On Tue, 31 Oct 2023 11:27:00 -0700, Elliot Berman wrote:
> syscon-reboot-mode.yaml should $ref: reboot-mode.yaml, but instead
> rewrites the properties. Update so it $refs instead.
>
>

Applied, thanks!

[1/1] dt-bindings: power: reset: $ref reboot-mode in syscon-reboot-mode
commit: 160dff476f81b928ee4a4d2be95066fa32513483

Best regards,
--
Sebastian Reichel <[email protected]>