2023-11-01 15:56:36

by Christophe JAILLET

Subject: [PATCH] mfd: intel-lpss: Remove usage of the deprecated ida_simple_xx() API

ida_alloc() and ida_free() should be preferred to the deprecated
ida_simple_get() and ida_simple_remove().

This is less verbose.

Signed-off-by: Christophe JAILLET <[email protected]>
---
drivers/mfd/intel-lpss.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/intel-lpss.c b/drivers/mfd/intel-lpss.c
index 9591b354072a..9115ba4c768f 100644
--- a/drivers/mfd/intel-lpss.c
+++ b/drivers/mfd/intel-lpss.c
@@ -405,7 +405,7 @@ int intel_lpss_probe(struct device *dev,

intel_lpss_init_dev(lpss);

- lpss->devid = ida_simple_get(&intel_lpss_devid_ida, 0, 0, GFP_KERNEL);
+ lpss->devid = ida_alloc(&intel_lpss_devid_ida, GFP_KERNEL);
if (lpss->devid < 0)
return lpss->devid;

@@ -442,7 +442,7 @@ int intel_lpss_probe(struct device *dev,
intel_lpss_unregister_clock(lpss);

err_clk_register:
- ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);
+ ida_free(&intel_lpss_devid_ida, lpss->devid);

return ret;
}
@@ -456,7 +456,7 @@ void intel_lpss_remove(struct device *dev)
intel_lpss_debugfs_remove(lpss);
intel_lpss_ltr_hide(lpss);
intel_lpss_unregister_clock(lpss);
- ida_simple_remove(&intel_lpss_devid_ida, lpss->devid);
+ ida_free(&intel_lpss_devid_ida, lpss->devid);
}
EXPORT_SYMBOL_GPL(intel_lpss_remove);

--
2.34.1

2023-11-23 10:57:48

by Lee Jones

Subject: Re: (subset) [PATCH] mfd: intel-lpss: Remove usage of the deprecated ida_simple_xx() API

On Wed, 01 Nov 2023 16:55:38 +0100, Christophe JAILLET wrote:
> ida_alloc() and ida_free() should be preferred to the deprecated
> ida_simple_get() and ida_simple_remove().
>
> This is less verbose.
>
>

Applied, thanks!

[1/1] mfd: intel-lpss: Remove usage of the deprecated ida_simple_xx() API
commit: 1026cd156d1099e0999f060a23af7470a8530efc

--
Lee Jones [李琼斯]